Issue 2822293003: Change highlight int to Integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2822293003: Change highlight int to Integer (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Change highlight int to Integer Move the highlight int to an Integer to allow null. This allows 0 to be a valid id, which it turns out is the case in CCTs. BUG=711523 Review-Url: https://codereview.chromium.org/2814243004 Cr-Commit-Position: refs/heads/master@{#464996} (cherry picked from commit 13b8f41be9f248fd67aa1188fc453a06e3825b6d) Review-Url: https://codereview.chromium.org/2822293003 . Cr-Commit-Position: refs/branch-heads/3071@{#39} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d67225af599e58ef3f2b29cbd23754751cc9ff6c

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -16 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java	View	4 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 2 (1 generated)

David Trainor- moved to gerrit

3 years, 8 months ago (2017-04-18 21:06:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d67225af599e58ef3f2b29cbd23754751cc9ff6c.