Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Issue 2814243004: Change highlight int to Integer (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit
Modified:
3 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change highlight int to Integer Move the highlight int to an Integer to allow null. This allows 0 to be a valid id, which it turns out is the case in CCTs. BUG=711523 Review-Url: https://codereview.chromium.org/2814243004 Cr-Commit-Position: refs/heads/master@{#464996} Committed: https://chromium.googlesource.com/chromium/src/+/13b8f41be9f248fd67aa1188fc453a06e3825b6d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Fixed comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 1 2 4 chunks +10 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (17 generated)
David Trainor- moved to gerrit
ptal thanks!
3 years, 8 months ago (2017-04-14 06:55:54 UTC) #2
Yusuf
lgtm https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java (right): https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java#newcode143 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:143: * be {@code null} if no item should ...
3 years, 8 months ago (2017-04-14 18:48:16 UTC) #7
David Trainor- moved to gerrit
https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java (right): https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java#newcode143 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:143: * be {@code null} if no item should be ...
3 years, 8 months ago (2017-04-14 23:36:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814243004/40001
3 years, 8 months ago (2017-04-17 20:08:18 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 20:13:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13b8f41be9f248fd67aa1188fc45...

Powered by Google App Engine
This is Rietveld 408576698