Change highlight int to Integer

Change highlight int to Integer

Move the highlight int to an Integer to allow null.  This allows 0 to be
a valid id, which it turns out is the case in CCTs.

BUG=711523
Review-Url: https://codereview.chromium.org/2814243004
Cr-Commit-Position: refs/heads/master@{#464996}
Committed: https://chromium.googlesource.com/chromium/src/+/13b8f41be9f248fd67aa1188fc453a06e3825b6d

[David Trainor- moved to gerrit, 2017-04-14 06:55:54]

dtrainor@chromium.org changed reviewers:
+ yusufo@chromium.org

[David Trainor- moved to gerrit, 2017-04-14 06:55:54]

ptal thanks!

[David Trainor- moved to gerrit, 2017-04-14 06:55:59]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 06:56:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 07:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 07:49:29]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Yusuf, 2017-04-14 18:48:16]

lgtm

https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
(right):

https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:143: * 
                          be {@code null} if no item should be highlighted.
should we have something around 0 being dedicated to custom menu items declared
by external apps?

A comment like this, probably would have helped you :).

[David Trainor- moved to gerrit, 2017-04-14 23:36:00]

https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
(right):

https://codereview.chromium.org/2814243004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:143: * 
                          be {@code null} if no item should be highlighted.
On 2017/04/14 18:48:15, Yusuf wrote:
> should we have something around 0 being dedicated to custom menu items
declared
> by external apps?
> 
> A comment like this, probably would have helped you :).

good idea!

[David Trainor- moved to gerrit, 2017-04-14 23:36:24]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:36:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 00:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 00:34:40]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[David Trainor- moved to gerrit, 2017-04-17 17:49:01]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 17:49:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:30:53]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-04-17 20:07:52]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-17 20:07:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2814243004/#ps40001
(title: "Fixed comparison")

[commit-bot: I haz the power, 2017-04-17 20:08:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:13:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492459672743240,
"parent_rev": "22015e2a880a0b124e2321d95363aee141786318", "commit_rev":
"13b8f41be9f248fd67aa1188fc453a06e3825b6d"}

[commit-bot: I haz the power, 2017-04-17 20:13:39]

Description was changed from

==========
Change highlight int to Integer

Move the highlight int to an Integer to allow null.  This allows 0 to be
a valid id, which it turns out is the case in CCTs.

BUG=711523
==========

to

==========
Change highlight int to Integer

Move the highlight int to an Integer to allow null.  This allows 0 to be
a valid id, which it turns out is the case in CCTs.

BUG=711523

Review-Url: https://codereview.chromium.org/2814243004
Cr-Commit-Position: refs/heads/master@{#464996}
Committed:
https://chromium.googlesource.com/chromium/src/+/13b8f41be9f248fd67aa1188fc45...
==========

[commit-bot: I haz the power, 2017-04-17 20:13:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13b8f41be9f248fd67aa1188fc45...