Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3511)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 2822293003: Change highlight int to Integer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
index 4db03ea63f23349b6734c10aed091f716bd722de..ea3e2930f632dd84e7ae3ff13374304b32f7794c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
@@ -140,11 +140,13 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {
* @param footerResourceId The resource id for a view to add to the end of the menu list. Can
* be 0 if no such view is required.
* @param highlightedItemId The resource id of the menu item that should be highlighted. Can
- * be 0 if no item should be highlighted.
+ * be {@code null} if no item should be highlighted. Note that
+ * {@code 0} is dedicated to custom menu items and can be declared by
+ * external apps.
*/
void show(Context context, View anchorView, boolean isByPermanentButton, int screenRotation,
Rect visibleDisplayFrame, int screenHeight, @IdRes int footerResourceId,
- @IdRes int highlightedItemId) {
+ Integer highlightedItemId) {
mPopup = new ListPopupWindow(context, null, android.R.attr.popupMenuStyle);
mPopup.setModal(true);
mPopup.setAnchorView(anchorView);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698