[Telemetry] Ensure we try to get browser crash stacks everywhere.

[Telemetry] Ensure we try to get browser crash stacks everywhere.

There were several places we could crash but not try to get a stack. This should
take care of everything.

BUG=371613, 373385
R=achuith@chromium.org, dtu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270884

[achuithb, 2014-05-15 18:10:22]

lgtm

https://codereview.chromium.org/282223004/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/282223004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:272:
logging.warning('TabCrashException/TimeoutException in '
Turns out both warn and warning work :)

https://codereview.chromium.org/282223004/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/exceptions.py (right):

https://codereview.chromium.org/282223004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/exceptions.py:37: class
BrowserConnectionGoneException(BrowserGoneException):
Should this inherit from NativeBrowserCrashException instead? I don't really see
why BrowserConnectionGone should inherit from BrowserGone.

[dtu, 2014-05-15 21:56:45]

lgtm

I know there are outstanding comments, but I want to see this landed for issue
373385, so I'm going to commit.

https://chromiumcodereview.appspot.com/282223004/diff/1/tools/telemetry/telem...
File tools/telemetry/telemetry/core/exceptions.py (right):

https://chromiumcodereview.appspot.com/282223004/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/exceptions.py:37: class
BrowserConnectionGoneException(BrowserGoneException):
On 2014/05/15 18:10:22, achuithb wrote:
> Should this inherit from NativeBrowserCrashException instead? I don't really
see
> why BrowserConnectionGone should inherit from BrowserGone.

Maybe it should be the reverse, BrowserGone should inherit from ConnectionGone,
since logically missing browser process implies connection is dead, so it's a
subset. But I don't see a code-level reason why we make this distinction at all.

[dtu, 2014-05-15 21:57:00]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-05-15 21:58:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/282223004/1

[achuithb, 2014-05-15 21:59:16]

On 2014/05/15 21:56:45, dtu wrote:
> lgtm
> 
> I know there are outstanding comments, but I want to see this landed for issue
> 373385, so I'm going to commit.

No worries. lgtm

[commit-bot: I haz the power, 2014-05-15 23:28:41]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-16 00:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 00:40:59]

Failed to apply patch for
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:      
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index
9eead0108834750e86eea1da4bc79e84fc7f9b90..46fdd76cb9779ccc0d393d69914d5d5ad2e8fda7
100644
---
a/@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++
b/@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -166,7 +166,8 @@ class WebviewBackendSettings(AndroidBrowserBackendSettings):
                          'activity %s:%s to come up',
                          self.package,
                          self.activity)
-        raise exceptions.BrowserGoneException('Timeout waiting for PID.')
+        raise exceptions.BrowserGoneException(self.browser,
+                                              'Timeout waiting for PID.')
     return 'localabstract:webview_devtools_remote_%s' % str(pid)
 
 
@@ -339,7 +340,7 @@ class
AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
   def pid(self):
     pids = self._adb.ExtractPid(self._backend_settings.package)
     if not pids:
-      raise exceptions.BrowserGoneException(self.GetStackTrace())
+      raise exceptions.BrowserGoneException(self.browser)
     return int(pids[0])
 
   @property

[dtu, 2014-05-16 00:46:05]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-05-16 00:47:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/282223004/1

[commit-bot: I haz the power, 2014-05-16 00:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 00:50:03]

Failed to apply patch for
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:      
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index
9eead0108834750e86eea1da4bc79e84fc7f9b90..46fdd76cb9779ccc0d393d69914d5d5ad2e8fda7
100644
---
a/@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++
b/@master/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -166,7 +166,8 @@ class WebviewBackendSettings(AndroidBrowserBackendSettings):
                          'activity %s:%s to come up',
                          self.package,
                          self.activity)
-        raise exceptions.BrowserGoneException('Timeout waiting for PID.')
+        raise exceptions.BrowserGoneException(self.browser,
+                                              'Timeout waiting for PID.')
     return 'localabstract:webview_devtools_remote_%s' % str(pid)
 
 
@@ -339,7 +340,7 @@ class
AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
   def pid(self):
     pids = self._adb.ExtractPid(self._backend_settings.package)
     if not pids:
-      raise exceptions.BrowserGoneException(self.GetStackTrace())
+      raise exceptions.BrowserGoneException(self.browser)
     return int(pids[0])
 
   @property

[dtu, 2014-05-16 01:01:30]

Committed patchset #1 manually as r270884 (presubmit successful).

[Primiano Tucci (use gerrit), 2014-06-02 09:22:47]

https://codereview.chromium.org/282223004/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/282223004/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:169:
raise exceptions.BrowserGoneException(self.browser,
Uhm, not WebviewBackendSettings nor its parent (AndroidBrowserBackendSettings)
seem to have a |browser| field.

(Out of curiosity, how come pylint didn't get this?)

This is causing now the following in the WebView telemetry bot (in cases of
timeout):

Traceback (most recent call last):
  <module> at tools/perf/run_benchmark:25
    sys.exit(test_runner.main())
  main at tools/telemetry/telemetry/test_runner.py:285
    return command().Run(options)
  Run at tools/telemetry/telemetry/test_runner.py:164
    return min(255, self._test().Run(args))
  Run at tools/telemetry/telemetry/test.py:84
    results = page_runner.Run(test, ps, expectations, args)
  Run at tools/telemetry/telemetry/page/page_runner.py:405
    page, credentials_path, possible_browser, results, state)
  _PrepareAndRunPage at tools/telemetry/telemetry/page/page_runner.py:253
    credentials_path, page.archive_path)
  StartBrowserIfNeeded at tools/telemetry/telemetry/page/page_runner.py:59
    self.browser.Start()
  Start at tools/telemetry/telemetry/core/browser.py:302
    self._browser_backend.Start()
  Start at
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:293
    self._backend_settings.GetDevtoolsRemotePort())
  GetDevtoolsRemotePort at
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:169
    raise exceptions.BrowserGoneException(self.browser,
AttributeError: 'WebviewBackendSettings' object has no attribute 'browser'