Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 282223004: [Telemetry] Ensure we try to get browser crash stacks everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index 285d11fc2b406e00c6c979e28ace359df53c2270..b3b2384691e4f9cb8bf4c97f1191c68ab35173cf 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -136,10 +136,10 @@ class PageRunnerTests(unittest.TestCase):
class CrashyMeasurement(page_measurement.PageMeasurement):
has_crashed = False
- def MeasurePage(self, *_):
+ def MeasurePage(self, _, tab, __):
if not self.has_crashed:
self.has_crashed = True
- raise exceptions.BrowserGoneException()
+ raise exceptions.BrowserGoneException(tab.browser)
options = options_for_unittests.GetCopy()
options.output_format = 'csv'
« tools/telemetry/telemetry/core/exceptions.py ('K') | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698