Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 282223004: [Telemetry] Ensure we try to get browser crash stacks everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
index 2f467f198797d23122d40eee6fda75742e02afda..049b0786d8534829381fd52cb638ab97fcd35c52 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
@@ -144,7 +144,9 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
try:
util.WaitFor(self.HasBrowserFinishedLaunching, timeout=30)
except (util.TimeoutException, exceptions.ProcessGoneException) as e:
- raise exceptions.BrowserGoneException(self.GetStackTrace())
+ if not self.IsBrowserRunning():
+ raise exceptions.BrowserGoneException(self.browser, e)
+ raise exceptions.BrowserConnectionGoneException(self.browser, e)
def AllExtensionsLoaded():
# Extension pages are loaded from an about:blank page,
@@ -235,8 +237,8 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
if throw_network_exception:
raise e
if not self.IsBrowserRunning():
- raise exceptions.BrowserGoneException(e)
- raise exceptions.BrowserConnectionGoneException(e)
+ raise exceptions.BrowserGoneException(self.browser, e)
+ raise exceptions.BrowserConnectionGoneException(self.browser, e)
@property
def browser_directory(self):

Powered by Google App Engine
This is Rietveld 408576698