[Telemetry] Ensure we try to get browser crash stacks everywhere.

tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index 9eead0108834750e86eea1da4bc79e84fc7f9b90..46fdd76cb9779ccc0d393d69914d5d5ad2e8fda7 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -166,7 +166,8 @@ class WebviewBackendSettings(AndroidBrowserBackendSettings):
                          'activity %s:%s to come up',
                          self.package,
                          self.activity)
-        raise exceptions.BrowserGoneException('Timeout waiting for PID.')
+        raise exceptions.BrowserGoneException(self.browser,

[Primiano Tucci (use gerrit), 2014/06/02 09:22:47]

Uhm, not WebviewBackendSettings nor its parent (AndroidBrowserBackendSettings)
seem to have a |browser| field.

(Out of curiosity, how come pylint didn't get this?)

This is causing now the following in the WebView telemetry bot (in cases of
timeout):

Traceback (most recent call last):
  <module> at tools/perf/run_benchmark:25
    sys.exit(test_runner.main())
  main at tools/telemetry/telemetry/test_runner.py:285
    return command().Run(options)
  Run at tools/telemetry/telemetry/test_runner.py:164
    return min(255, self._test().Run(args))
  Run at tools/telemetry/telemetry/test.py:84
    results = page_runner.Run(test, ps, expectations, args)
  Run at tools/telemetry/telemetry/page/page_runner.py:405
    page, credentials_path, possible_browser, results, state)
  _PrepareAndRunPage at tools/telemetry/telemetry/page/page_runner.py:253
    credentials_path, page.archive_path)
  StartBrowserIfNeeded at tools/telemetry/telemetry/page/page_runner.py:59
    self.browser.Start()
  Start at tools/telemetry/telemetry/core/browser.py:302
    self._browser_backend.Start()
  Start at
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:293
    self._backend_settings.GetDevtoolsRemotePort())
  GetDevtoolsRemotePort at
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:169
    raise exceptions.BrowserGoneException(self.browser,
AttributeError: 'WebviewBackendSettings' object has no attribute 'browser'

+                                              'Timeout waiting for PID.')
     return 'localabstract:webview_devtools_remote_%s' % str(pid)
 
 
@@ -339,7 +340,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
   def pid(self):
     pids = self._adb.ExtractPid(self._backend_settings.package)
     if not pids:
-      raise exceptions.BrowserGoneException(self.GetStackTrace())
+      raise exceptions.BrowserGoneException(self.browser)
     return int(pids[0])
 
   @property