cros: Use SessionController to enable system tray settings / notifications tray

cros: Use SessionController to enable system tray settings / notifications tray

This eliminates 2 methods from SystemTrayDelegate and makes
the system tray work better in mustash.

* Rename ShouldShowSettings to ShouldEnableSettings, because
the settings gear icon is always visible.
* Cache the booleans from the user flow in ash::mojom::UserSession,
because these are set once per session
* Consolidate the session active/locked/etc. logic in SessionController
* Clean up WebNotificationTray, which uses logged in state and
should-show state inconsistently.

BUG=648964, 665997
TEST=ash_unittests TrayItemTest.*, manual testing of supervised user flow and adding secondary user flow

Review-Url: https://codereview.chromium.org/2822033002
Cr-Commit-Position: refs/heads/master@{#465287}
Committed: https://chromium.googlesource.com/chromium/src/+/341c0454a9e0c39895d2228e25a9fd57f919e16e

[James Cook, 2017-04-17 23:01:17]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 23:01:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-04-17 23:15:54]

Description was changed from

==========
cros: Use SessionController to enable system tray settings / notifications tray
format


fix


rename ShouldShowSettings to ShouldEnableSettings


cleanup


fix settings


Convert WebNotificationTray to use SessionController for visibility, tests pass


mash: Pass UserFlow info via SessionController

BUG=648964

Change-Id: Ieda582dd48548cb26cb55d5bdb88ae69ee7940ca

logs
==========

to

==========
cros: Use SessionController to enable system tray settings / notifications tray

This eliminates 2 methods from SystemTrayDelegate and makes
the system tray work better in mustash.

* Rename ShouldShowSettings to ShouldEnableSettings, because
the settings gear icon is always visible.
* Cache the booleans from the user flow in ash::mojom::UserSession,
because these are set once per session
* Consolidate the session active/locked/etc. logic in SessionController
* Clean up WebNotificationTray, which uses logged in state and
should-show state inconsistently.

BUG=648964,665997
TEST=ash_unittests TrayItemTest.*, manual testing of supervised user flow and
adding secondary user flow
==========

[James Cook, 2017-04-17 23:21:12]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2017-04-17 23:21:13]

xiyuan, please take a look.

https://codereview.chromium.org/2822033002/diff/1/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2822033002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:500: return
ShouldShowMessageCenter();
This was probably wrong before. The context menu contains a "Settings..." item,
which we should not show in supervised user flow, etc.

https://codereview.chromium.org/2822033002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:600: if
(ShouldShowMessageCenter())
It seemed weird to SetNextFocusableView() if |this| isn't visible. Also, I can't
get keyboard focus onto the tray icon no matter what I do -- Alt-Shift-N opens
the notifications menu, and Alt-Shift-S opens the status tray, and Alt-Shift-L
focuses the shelf, but I can't put focus on the icon. This might be dead code,
but I decided to keep it just in case.

[commit-bot: I haz the power, 2017-04-17 23:31:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:31:27]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-04-18 16:26:29]

lgtm

https://codereview.chromium.org/2822033002/diff/1/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2822033002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:500: return
ShouldShowMessageCenter();
On 2017/04/17 23:21:13, James Cook wrote:
> This was probably wrong before. The context menu contains a "Settings..."
item,
> which we should not show in supervised user flow, etc.

Acknowledged.

https://codereview.chromium.org/2822033002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:600: if
(ShouldShowMessageCenter())
On 2017/04/17 23:21:13, James Cook wrote:
> It seemed weird to SetNextFocusableView() if |this| isn't visible. Also, I
can't
> get keyboard focus onto the tray icon no matter what I do -- Alt-Shift-N opens
> the notifications menu, and Alt-Shift-S opens the status tray, and Alt-Shift-L
> focuses the shelf, but I can't put focus on the icon. This might be dead code,
> but I decided to keep it just in case.

Acknowledged.

[James Cook, 2017-04-18 17:16:35]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-04-18 17:17:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 17:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 17:27:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[James Cook, 2017-04-18 17:36:09]

jamescook@chromium.org changed reviewers:
+ tsepez@chromium.org

[James Cook, 2017-04-18 17:36:09]

tsepez, can I get OWNERS for adding a couple bools to
ash/public/interfaces/session_controller.mojom ?

[Tom Sepez, 2017-04-18 17:47:35]

OWNERS LGTM

[James Cook, 2017-04-18 17:59:01]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-04-18 17:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:04:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492538341183570, "parent_rev":
"c7c2bd2e10b17a437725111c233184ef430e689b", "commit_rev":
"341c0454a9e0c39895d2228e25a9fd57f919e16e"}

[commit-bot: I haz the power, 2017-04-18 18:04:30]

Description was changed from

==========
cros: Use SessionController to enable system tray settings / notifications tray

This eliminates 2 methods from SystemTrayDelegate and makes
the system tray work better in mustash.

* Rename ShouldShowSettings to ShouldEnableSettings, because
the settings gear icon is always visible.
* Cache the booleans from the user flow in ash::mojom::UserSession,
because these are set once per session
* Consolidate the session active/locked/etc. logic in SessionController
* Clean up WebNotificationTray, which uses logged in state and
should-show state inconsistently.

BUG=648964,665997
TEST=ash_unittests TrayItemTest.*, manual testing of supervised user flow and
adding secondary user flow
==========

to

==========
cros: Use SessionController to enable system tray settings / notifications tray

This eliminates 2 methods from SystemTrayDelegate and makes
the system tray work better in mustash.

* Rename ShouldShowSettings to ShouldEnableSettings, because
the settings gear icon is always visible.
* Cache the booleans from the user flow in ash::mojom::UserSession,
because these are set once per session
* Consolidate the session active/locked/etc. logic in SessionController
* Clean up WebNotificationTray, which uses logged in state and
should-show state inconsistently.

BUG=648964,665997
TEST=ash_unittests TrayItemTest.*, manual testing of supervised user flow and
adding secondary user flow

Review-Url: https://codereview.chromium.org/2822033002
Cr-Commit-Position: refs/heads/master@{#465287}
Committed:
https://chromium.googlesource.com/chromium/src/+/341c0454a9e0c39895d2228e25a9...
==========

[commit-bot: I haz the power, 2017-04-18 18:04:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/341c0454a9e0c39895d2228e25a9...