cros: Disable system tray help/lock buttons during supervised user creation

cros: Disable system tray help/lock buttons during supervised user creation

Neither button does anything during supervised user creation, so disable
them both.

Also disable settings buttons for Bluetooth and IME tray menu during this
flow, as those don't work either.

Clean up some cases where we were caching the login state and don't need to.

BUG=712701
TEST=ash_unittests, added TrayTilesTest.ButtonStatesSupervisedUserFlow,
manually check IME menu and bluetooth

Review-Url: https://codereview.chromium.org/2821363002
Cr-Commit-Position: refs/heads/master@{#465404}
Committed: https://chromium.googlesource.com/chromium/src/+/85312ee5ec5652a88b9b345d53f92ae261a0d451

[James Cook, 2017-04-18 17:45:38]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 17:46:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-04-18 17:50:19]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2017-04-18 17:50:20]

xiyuan, please take a look.

https://codereview.chromium.org/2821363002/diff/20001/ash/system/ime_menu/ime...
File ash/system/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2821363002/diff/20001/ash/system/ime_menu/ime...
ash/system/ime_menu/ime_menu_tray.cc:88: bool IsInLoginOrLockScreen() {
It's unclear to me exactly how the IME menu should behave during the supervised
user flow, so I kept this logic roughly the same.

[James Cook, 2017-04-18 18:08:52]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-04-18 18:34:26]

lgtm

https://codereview.chromium.org/2821363002/diff/20001/ash/system/ime_menu/ime...
File ash/system/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2821363002/diff/20001/ash/system/ime_menu/ime...
ash/system/ime_menu/ime_menu_tray.cc:88: bool IsInLoginOrLockScreen() {
On 2017/04/18 17:50:20, James Cook wrote:
> It's unclear to me exactly how the IME menu should behave during the
supervised
> user flow, so I kept this logic roughly the same.

Acknowledged.

[James Cook, 2017-04-18 19:06:33]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-04-18 19:06:39]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:06:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:31:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-04-18 22:16:18]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-04-18 22:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2821363002/#ps60001
(title: "fix browser test")

[commit-bot: I haz the power, 2017-04-18 22:16:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 22:47:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492553778173640,
"parent_rev": "9c9718a7949178f62182ee59a3ba127584beb78c", "commit_rev":
"85312ee5ec5652a88b9b345d53f92ae261a0d451"}

[commit-bot: I haz the power, 2017-04-18 22:48:00]

Description was changed from

==========
cros: Disable system tray help/lock buttons during supervised user creation

Neither button does anything during supervised user creation, so disable
them both.

Also disable settings buttons for Bluetooth and IME tray menu during this
flow, as those don't work either.

Clean up some cases where we were caching the login state and don't need to.

BUG=712701
TEST=ash_unittests, added TrayTilesTest.ButtonStatesSupervisedUserFlow,
manually check IME menu and bluetooth
==========

to

==========
cros: Disable system tray help/lock buttons during supervised user creation

Neither button does anything during supervised user creation, so disable
them both.

Also disable settings buttons for Bluetooth and IME tray menu during this
flow, as those don't work either.

Clean up some cases where we were caching the login state and don't need to.

BUG=712701
TEST=ash_unittests, added TrayTilesTest.ButtonStatesSupervisedUserFlow,
manually check IME menu and bluetooth

Review-Url: https://codereview.chromium.org/2821363002
Cr-Commit-Position: refs/heads/master@{#465404}
Committed:
https://chromium.googlesource.com/chromium/src/+/85312ee5ec5652a88b9b345d53f9...
==========

[commit-bot: I haz the power, 2017-04-18 22:48:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/85312ee5ec5652a88b9b345d53f9...