Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5007)

Unified Diff: chrome/browser/chromeos/login/user_flow.h

Issue 2822033002: cros: Use SessionController to enable system tray settings / notifications tray (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_flow.h
diff --git a/chrome/browser/chromeos/login/user_flow.h b/chrome/browser/chromeos/login/user_flow.h
index 23c9094ac5f033cf93043b919288d1c5016bf3bd..a11b004e037f49736329553a8657f3c00dd5bd73 100644
--- a/chrome/browser/chromeos/login/user_flow.h
+++ b/chrome/browser/chromeos/login/user_flow.h
@@ -29,8 +29,13 @@ class UserFlow {
// Indicates if screen locking should be enabled or disabled for a flow.
virtual bool CanLockScreen() = 0;
virtual bool CanStartArc() = 0;
- virtual bool ShouldShowSettings() = 0;
+
+ // Whether or not the settings icon should be enabled in the system tray menu.
+ virtual bool ShouldEnableSettings() = 0;
+
+ // Whether or not the notifications tray should be visible.
virtual bool ShouldShowNotificationTray() = 0;
+
virtual bool ShouldLaunchBrowser() = 0;
virtual bool ShouldSkipPostLoginScreens() = 0;
virtual bool SupportsEarlyRestartToApplyFlags() = 0;
@@ -55,10 +60,11 @@ class DefaultUserFlow : public UserFlow {
public:
~DefaultUserFlow() override;
+ // UserFlow:
void AppendAdditionalCommandLineSwitches() override;
bool CanLockScreen() override;
bool CanStartArc() override;
- bool ShouldShowSettings() override;
+ bool ShouldEnableSettings() override;
bool ShouldShowNotificationTray() override;
bool ShouldLaunchBrowser() override;
bool ShouldSkipPostLoginScreens() override;
@@ -77,8 +83,9 @@ class ExtendedUserFlow : public UserFlow {
explicit ExtendedUserFlow(const AccountId& account_id);
~ExtendedUserFlow() override;
+ // UserFlow:
void AppendAdditionalCommandLineSwitches() override;
- bool ShouldShowSettings() override;
+ bool ShouldEnableSettings() override;
bool ShouldShowNotificationTray() override;
void HandleOAuthTokenStatusChange(
user_manager::User::OAuthTokenStatus status) override;

Powered by Google App Engine
This is Rietveld 408576698