Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2821963002: Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. (Closed)

Created:
3 years, 8 months ago by oshima
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the main window is deleted (thus, window frame is empty) which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. Review-Url: https://codereview.chromium.org/2820493004 Cr-Commit-Position: refs/heads/master@{#464819} (cherry picked from commit ae72f92d7caba6d32ba2a11f32943f29af15c3d8) Review-Url: https://codereview.chromium.org/2821963002 . Cr-Commit-Position: refs/branch-heads/3071@{#52} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4d5dad8b29ff50856c5565610dedc7d17aaf0080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M components/exo/shell_surface.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 8 months ago (2017-04-19 16:48:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d5dad8b29ff50856c5565610dedc7d17aaf0080.

Powered by Google App Engine
This is Rietveld 408576698