WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=714240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821363003
Cr-Commit-Position: refs/heads/master@{#468257}
Committed: https://chromium.googlesource.com/chromium/src/+/2a7adc3543e9b9b0bf44563830a3502ceba76650

[aleksandar.stojiljkovic, 2017-04-19 11:46:26]

Description was changed from

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

Do not commit. This is work in progress - DEPS points to forked repository.

BUG=
==========

to

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

Do not commit. This is work in progress - DEPS points to forked repository.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[aleksandar.stojiljkovic, 2017-04-19 17:38:27]

Patchset #1 (id:1) has been deleted

[aleksandar.stojiljkovic, 2017-04-19 17:38:48]

Patchset #1 (id:20001) has been deleted

[aleksandar.stojiljkovic, 2017-04-19 17:38:57]

Patchset #1 (id:40001) has been deleted

[aleksandar.stojiljkovic, 2017-04-19 17:43:48]

Description was changed from

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

Do not commit. This is work in progress - DEPS points to forked repository.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-04-21 17:42:31]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-04-21 17:42:32]

Hi Aleks, did you mean to send this out for review? If so then you need to
explicitly publish and mail comments, and select reviewers, to do so.

Please refer to a bug ID in the description. Thanks.

[aleksandar.stojiljkovic, 2017-04-21 19:53:19]

Description was changed from

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=714240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[aleksandar.stojiljkovic, 2017-04-21 19:54:39]

On 2017/04/21 17:42:32, Ken Russell wrote:
> Hi Aleks, did you mean to send this out for review? If so then you need to
> explicitly publish and mail comments, and select reviewers, to do so.
> 
> Please refer to a bug ID in the description. Thanks.

Yes, thanks. I thought it was a good idea to land the spec change and
conformance tests first. Added the bug ID.

[aleksandar.stojiljkovic, 2017-04-21 19:55:15]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ zmo@chromium.org

[aleksandar.stojiljkovic, 2017-04-21 19:55:15]

PTAL. Thanks.

[Ken Russell (switch to Gerrit), 2017-04-27 02:57:22]

I'm sorry for the delay reviewing this.

LGTM. Let's land this and then re-land
https://github.com/KhronosGroup/WebGL/pull/2375 so that we don't have to add
tons of temporary suppressions for failing conformance tests.

[aleksandar.stojiljkovic, 2017-04-27 07:02:35]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com

[commit-bot: I haz the power, 2017-04-27 07:02:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:50:19]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[aleksandar.stojiljkovic, 2017-04-27 08:40:56]

On 2017/04/27 07:50:19, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

On 2017/04/27 02:57:22, Ken Russell wrote:
> I'm sorry for the delay reviewing this.
> 
> LGTM. Let's land this and then re-land
> https://github.com/KhronosGroup/WebGL/pull/2375 so that we don't have to add
> tons of temporary suppressions for failing conformance tests.

Unexpected Failures:
*
gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_misc_tex_image_with_bad_args_from_dom_elements
*
gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_misc_tex_image_with_different_data_source

The changes to
sdk/tests/conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html
[1]
and
sdk/tests/conformance2/textures/misc/tex-image-with-different-data-source.html
(are part of https://github.com/KhronosGroup/WebGL/pull/2375/)
are required to land this.

I've split the changes to another PR:
https://github.com/KhronosGroup/WebGL/pull/2386.

So, the plan is to:
1. land PR 2386
2. roll to the most recent WebGL to chromium
3. land this
4. make new PR, rebased https://github.com/KhronosGroup/WebGL/pull/2375.

[1]
https://github.com/KhronosGroup/WebGL/pull/2375/commits/be7ea4e0ad0de4a0000e2...

[Ken Russell (switch to Gerrit), 2017-04-27 23:19:51]

On 2017/04/27 08:40:56, aleksandar.stojiljkovic wrote:
> On 2017/04/27 07:50:19, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> 
> On 2017/04/27 02:57:22, Ken Russell wrote:
> > I'm sorry for the delay reviewing this.
> > 
> > LGTM. Let's land this and then re-land
> > https://github.com/KhronosGroup/WebGL/pull/2375 so that we don't have to add
> > tons of temporary suppressions for failing conformance tests.
> 
> Unexpected Failures:
> *
>
gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_misc_tex_image_with_bad_args_from_dom_elements
> *
>
gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_misc_tex_image_with_different_data_source
> 
> The changes to
>
sdk/tests/conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html
> [1]
> and
> sdk/tests/conformance2/textures/misc/tex-image-with-different-data-source.html
> (are part of https://github.com/KhronosGroup/WebGL/pull/2375/)
> are required to land this.
> 
> I've split the changes to another PR:
> https://github.com/KhronosGroup/WebGL/pull/2386.
> 
> So, the plan is to:
> 1. land PR 2386
> 2. roll to the most recent WebGL to chromium
> 3. land this
> 4. make new PR, rebased https://github.com/KhronosGroup/WebGL/pull/2375.
> 
> [1]
>
https://github.com/KhronosGroup/WebGL/pull/2375/commits/be7ea4e0ad0de4a0000e2...

Plan sounds fine. It would also be OK IMO to mark just these two tests as
failing in this CL, and then remove those expectations once you've rolled
forward the WebGL conformance suite.

[aleksandar.stojiljkovic, 2017-04-28 08:50:22]

On 2017/04/27 23:19:51, Ken Russell wrote:
> On 2017/04/27 08:40:56, aleksandar.stojiljkovic wrote:
> > On 2017/04/27 07:50:19, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> > 
> > On 2017/04/27 02:57:22, Ken Russell wrote:
> > > I'm sorry for the delay reviewing this.
> > > 
> > > LGTM. Let's land this and then re-land
> > > https://github.com/KhronosGroup/WebGL/pull/2375 so that we don't have to
add
> > > tons of temporary suppressions for failing conformance tests.
> > 
> > Unexpected Failures:
> > *
> >
>
gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_misc_tex_image_with_bad_args_from_dom_elements
> > *
> >
>
gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_misc_tex_image_with_different_data_source
> > 
> > The changes to
> >
>
sdk/tests/conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html
> > [1]
> > and
> >
sdk/tests/conformance2/textures/misc/tex-image-with-different-data-source.html
> > (are part of https://github.com/KhronosGroup/WebGL/pull/2375/)
> > are required to land this.
> > 
> > I've split the changes to another PR:
> > https://github.com/KhronosGroup/WebGL/pull/2386.
> > 
> > So, the plan is to:
> > 1. land PR 2386
> > 2. roll to the most recent WebGL to chromium
> > 3. land this
> > 4. make new PR, rebased https://github.com/KhronosGroup/WebGL/pull/2375.
> > 
> > [1]
> >
>
https://github.com/KhronosGroup/WebGL/pull/2375/commits/be7ea4e0ad0de4a0000e2...
> 
> Plan sounds fine. It would also be OK IMO to mark just these two tests as
> failing in this CL, and then remove those expectations once you've rolled
> forward the WebGL conformance suite.

Thanks. No problem, the roll seems to be coming soon:
https://codereview.chromium.org/2844363004.

[aleksandar.stojiljkovic, 2017-04-30 18:09:29]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com

[commit-bot: I haz the power, 2017-04-30 18:09:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 21:15:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493575769240060,
"parent_rev": "67525cc21428aa4c1f84968f147fc1cdb91ac864", "commit_rev":
"2a7adc3543e9b9b0bf44563830a3502ceba76650"}

[commit-bot: I haz the power, 2017-04-30 21:16:08]

Description was changed from

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=714240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures.

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=714240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821363003
Cr-Commit-Position: refs/heads/master@{#468257}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a7adc3543e9b9b0bf44563830a3...
==========

[commit-bot: I haz the power, 2017-04-30 21:16:10]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2a7adc3543e9b9b0bf44563830a3...