Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2821323002: Optimize offscreen animation: don't update paint properties/visual rects (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize offscreen animation: don't update paint properties/visual rects CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2821323002 Cr-Commit-Position: refs/heads/master@{#468081} Committed: https://chromium.googlesource.com/chromium/src/+/10056cdd779bbd3d6f0949cbba2c7355992b3e8d

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : Add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -15 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp View 1 2 3 3 chunks +48 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
Xianzhu
3 years, 8 months ago (2017-04-21 18:01:49 UTC) #15
chrishtr
Could you add a unittest for this?
3 years, 8 months ago (2017-04-21 18:13:52 UTC) #16
Xianzhu
On 2017/04/21 18:13:52, chrishtr wrote: > Could you add a unittest for this? Done.
3 years, 8 months ago (2017-04-24 17:35:10 UTC) #20
Xianzhu
On 2017/04/24 17:35:10, Xianzhu wrote: > On 2017/04/21 18:13:52, chrishtr wrote: > > Could you ...
3 years, 7 months ago (2017-04-27 22:36:37 UTC) #21
chrishtr
lgtm
3 years, 7 months ago (2017-04-27 23:04:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821323002/120001
3 years, 7 months ago (2017-04-28 16:56:45 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 19:00:36 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/10056cdd779bbd3d6f0949cbba2c...

Powered by Google App Engine
This is Rietveld 408576698