third_party/WebKit/Source/core/layout/LayoutImage.cpp - Issue 2821323002: Optimize offscreen animation: don't update paint properties/visual rects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutImage.cpp

Issue 2821323002: Optimize offscreen animation: don't update paint properties/visual rects (Closed)

Patch Set: Add unit test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutImage.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutImage.cpp b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

index 73d3a8ae1fad95c45ce1f893cd0f670be89f9aac..0ae3d202cf2ec5b6bea990455c627a83a5b4bbeb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutImage.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

@@ -170,10 +170,10 @@ void LayoutImage::InvalidatePaintAndMarkForLayoutIfNeeded() {

return;

}

- if (ImageResource() && ImageResource()->MaybeAnimated())

- SetShouldDoFullPaintInvalidation(kPaintInvalidationDelayedFull);

- else

- SetShouldDoFullPaintInvalidation(kPaintInvalidationFull);

+ SetShouldDoFullPaintInvalidationWithoutGeometryChange(

+ ImageResource() && ImageResource()->MaybeAnimated()

+ ? kPaintInvalidationDelayedFull

+ : kPaintInvalidationFull);

// Tell any potential compositing layers that the image needs updating.

ContentChanged(kImageChanged);