Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2821303003: Move a browser-side File API unittest next to the file it covers. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, kinuko
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, jam, nhiroki, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move a browser-side File API unittest next to the file it covers. BUG=653751 Review-Url: https://codereview.chromium.org/2821303003 Cr-Commit-Position: refs/heads/master@{#465493} Committed: https://chromium.googlesource.com/chromium/src/+/82195125039f3fe5e7dc29ab7c382767750eb2ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -482 lines) Patch
M chrome/browser/extensions/app_data_migrator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D content/public/test/mock_blob_url_request_context.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/public/test/mock_blob_url_request_context.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M storage/browser/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + storage/browser/fileapi/file_system_operation_impl_write_unittest.cc View 9 chunks +10 lines, -20 lines 0 comments Download
A + storage/browser/test/mock_blob_url_request_context.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_blob_url_request_context.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
pwnall
thestig@chromium.org: Please review changes in chrome/browser/extensions/app_data_migrator_unittest.cc kinuko@chromium.org: Please review the rest of the CL.
3 years, 8 months ago (2017-04-18 22:35:26 UTC) #4
Lei Zhang
On 2017/04/18 22:35:26, pwnall wrote: > mailto:thestig@chromium.org: Please review changes in > chrome/browser/extensions/app_data_migrator_unittest.cc lgtm
3 years, 8 months ago (2017-04-18 23:06:49 UTC) #5
kinuko
lgtm
3 years, 8 months ago (2017-04-19 03:00:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821303003/1
3 years, 8 months ago (2017-04-19 04:23:50 UTC) #10
pwnall
On 2017/04/19 03:00:24, kinuko wrote: > lgtm thestig, kinuko: Thank you very much for the ...
3 years, 8 months ago (2017-04-19 04:23:56 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 04:37:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82195125039f3fe5e7dc29ab7c38...

Powered by Google App Engine
This is Rietveld 408576698