Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2820113005: Move two browser-side File API unittests next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move two browser-side File API unittests next to the files they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2820113005 Cr-Commit-Position: refs/heads/master@{#465486} Committed: https://chromium.googlesource.com/chromium/src/+/598ef63820b8296b70793a3a50b7e923ea90b484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1118 lines) Patch
D content/browser/fileapi/sandbox_database_test_helper.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/browser/fileapi/sandbox_database_test_helper.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D content/browser/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +0 lines, -677 lines 0 comments Download
D content/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +0 lines, -309 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M storage/browser/BUILD.gn View 4 chunks +7 lines, -2 lines 0 comments Download
A + storage/browser/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/sandbox_database_test_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/sandbox_database_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
pwnall
PTAL? Getting close to being done :)
3 years, 8 months ago (2017-04-18 20:58:21 UTC) #4
kinuko
lgtm
3 years, 8 months ago (2017-04-19 02:59:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113005/1
3 years, 8 months ago (2017-04-19 03:47:58 UTC) #9
pwnall
On 2017/04/19 02:59:47, kinuko wrote: > lgtm Thank you very much for the quick turnaround!
3 years, 8 months ago (2017-04-19 03:48:09 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 03:51:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/598ef63820b8296b70793a3a50b7...

Powered by Google App Engine
This is Rietveld 408576698