Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2820143005: Move a browser-side WebSQL unittest next to the file it covers. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move a browser-side WebSQL unittest next to the file it covers. BUG=653751 Review-Url: https://codereview.chromium.org/2820143005 Cr-Commit-Position: refs/heads/master@{#465499} Committed: https://chromium.googlesource.com/chromium/src/+/cb1b13c2139eac564415e378055d5934207635ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -955 lines) Patch
D content/browser/database_tracker_unittest.cc View 1 chunk +0 lines, -855 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + storage/browser/database/database_tracker_unittest.cc View 26 chunks +62 lines, -99 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
pwnall
PTAL? This is the last moving patch, for a while :) I'll start fixing up ...
3 years, 8 months ago (2017-04-18 22:47:45 UTC) #4
kinuko
On 2017/04/18 22:47:45, pwnall wrote: > PTAL? > > This is the last moving patch, ...
3 years, 8 months ago (2017-04-19 03:00:56 UTC) #7
pwnall
On 2017/04/19 03:00:56, kinuko wrote: > On 2017/04/18 22:47:45, pwnall wrote: > > PTAL? > ...
3 years, 8 months ago (2017-04-19 05:24:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820143005/1
3 years, 8 months ago (2017-04-19 05:24:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 05:31:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb1b13c2139eac564415e378055d...

Powered by Google App Engine
This is Rietveld 408576698