Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2821053004: Revert of Remove the code to store and load QUIC server configs in the disk cache. (Closed)

Created:
3 years, 8 months ago by aboxhall
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the code to store and load QUIC server configs in the disk cache. (patchset #13 id:240001 of https://codereview.chromium.org/2820573004/ ) Reason for revert: Lots of MSan failures: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/89/steps/net_unittests Original issue's description: > Remove the code to store and load QUIC server configs in the disk cache. > > This includes the load_server_info_time_to_srtt, enable_connection_racing and disable_disk_cache finch options. > > BUG=707953 > > Review-Url: https://codereview.chromium.org/2820573004 > Cr-Commit-Position: refs/heads/master@{#465474} > Committed: https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f02f94d76d2dda TBR=ianswett@google.com,jri@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707953 Review-Url: https://codereview.chromium.org/2821053004 Cr-Commit-Position: refs/heads/master@{#465502} Committed: https://chromium.googlesource.com/chromium/src/+/5644040ec767fafe48393e5186901da9452464d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2260 lines, -89 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 3 chunks +37 lines, -0 lines 0 comments Download
M net/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A net/http/disk_cache_based_quic_server_info.h View 1 chunk +135 lines, -0 lines 0 comments Download
A net/http/disk_cache_based_quic_server_info.cc View 1 chunk +450 lines, -0 lines 0 comments Download
A net/http/disk_cache_based_quic_server_info_unittest.cc View 1 chunk +721 lines, -0 lines 0 comments Download
M net/http/http_cache.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +9 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +12 lines, -1 line 0 comments Download
M net/quic/chromium/properties_based_quic_server_info.h View 2 chunks +23 lines, -1 line 0 comments Download
M net/quic/chromium/properties_based_quic_server_info.cc View 2 chunks +52 lines, -4 lines 0 comments Download
M net/quic/chromium/properties_based_quic_server_info_test.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 3 chunks +34 lines, -1 line 0 comments Download
M net/quic/chromium/quic_server_info.h View 5 chunks +80 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_server_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 9 chunks +50 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 24 chunks +243 lines, -15 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_peer.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_peer.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 21 chunks +195 lines, -57 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
aboxhall
Created Revert of Remove the code to store and load QUIC server configs in the ...
3 years, 8 months ago (2017-04-19 05:45:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821053004/1
3 years, 8 months ago (2017-04-19 05:45:47 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 05:47:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5644040ec767fafe48393e518690...

Powered by Google App Engine
This is Rietveld 408576698