Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2821053004: Revert of Remove the code to store and load QUIC server configs in the disk cache. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index b9a21af5e9c7183f624cec89b4af544682c97560..0a52ae01f8aa64236e78bf14429a7959feeb2042 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -70,8 +70,11 @@
EXPECT_FALSE(params_.retry_without_alt_svc_on_quic_errors);
EXPECT_EQ(1350u, params_.quic_max_packet_length);
EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
+ EXPECT_EQ(0.25f, params_.quic_load_server_info_timeout_srtt_multiplier);
+ EXPECT_FALSE(params_.quic_enable_connection_racing);
EXPECT_FALSE(params_.enable_server_push_cancellation);
EXPECT_FALSE(params_.quic_enable_non_blocking_io);
+ EXPECT_FALSE(params_.quic_disable_disk_cache);
EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
params_.quic_idle_connection_timeout_seconds);
@@ -336,6 +339,29 @@
EXPECT_EQ(expected_settings, params_.http2_settings);
}
+TEST_F(NetworkSessionConfiguratorTest,
+ QuicLoadServerInfoTimeToSmoothedRttFromFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["load_server_info_time_to_srtt"] = "0.5";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_EQ(0.5f, params_.quic_load_server_info_timeout_srtt_multiplier);
+}
+
+TEST_F(NetworkSessionConfiguratorTest, QuicEnableConnectionRacing) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["enable_connection_racing"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_TRUE(params_.quic_enable_connection_racing);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicEnableNonBlockingIO) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["enable_non_blocking_io"] = "true";
@@ -345,6 +371,17 @@
ParseFieldTrials();
EXPECT_TRUE(params_.quic_enable_non_blocking_io);
+}
+
+TEST_F(NetworkSessionConfiguratorTest, QuicDisableDiskCache) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["disable_disk_cache"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_TRUE(params_.quic_disable_disk_cache);
}
TEST_F(NetworkSessionConfiguratorTest, TCPFastOpenHttpsEnabled) {
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698