Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2816043005: Revert of Introduce ModulePendingScript (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) Reason for revert: Reason for revert: https://codereview.chromium.org/2653923008/ is suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Introduce ModulePendingScript > > BUG=594639 > > Review-Url: https://codereview.chromium.org/2815453006 > Cr-Commit-Position: refs/heads/master@{#464627} > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5 TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639 Review-Url: https://codereview.chromium.org/2816043005 Cr-Commit-Position: refs/heads/master@{#464765} Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78cc4473eb50c6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -189 lines) Patch
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ModulePendingScript.h View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ModulePendingScript.cpp View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hiroshige
Created Revert of Introduce ModulePendingScript
3 years, 8 months ago (2017-04-14 18:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816043005/1
3 years, 8 months ago (2017-04-14 18:55:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78cc4473eb50c6f
3 years, 8 months ago (2017-04-14 18:57:15 UTC) #6
hiroshige
3 years, 8 months ago (2017-04-14 22:42:39 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2820703003/ by hiroshige@chromium.org.

The reason for reverting is: Issue 711703 is fixed on
https://codereview.chromium.org/2653923008/.
.

Powered by Google App Engine
This is Rietveld 408576698