Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2820633003: Media Controls: move simple buttons to modules/. (Closed)

Created:
3 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 8 months ago
Reviewers:
whywhat
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: move simple buttons to modules/. This is moving the simple buttons, leaving two buttons with some more logic and the two sliders. BUG=662761 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2820633003 Cr-Commit-Position: refs/heads/master@{#464741} Committed: https://chromium.googlesource.com/chromium/src/+/e4e2060346a37d1916e79ad33692c27722cfd917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -364 lines) Patch
M third_party/WebKit/Source/core/html/media/MediaControls.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.h View 2 chunks +0 lines, -98 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +0 lines, -230 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h View 3 chunks +17 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp View 8 chunks +19 lines, -23 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.h View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp View 1 chunk +68 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
mlamouri (slow - plz ping)
avayvod@ PTAL, download and cast buttons are next
3 years, 8 months ago (2017-04-14 10:14:06 UTC) #3
whywhat
lgtm unless there're any particular bits of code you'd like me to nitpick on :)
3 years, 8 months ago (2017-04-14 16:21:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820633003/1
3 years, 8 months ago (2017-04-14 17:04:48 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 17:12:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4e2060346a37d1916e79ad33692...

Powered by Google App Engine
This is Rietveld 408576698