Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2820633003: Media Controls: move simple buttons to modules/. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index 5271632ae12dd888d3ab72e77990416361b34e38..097b1624daf843e46558cc92bc9d064738fe0619 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -39,13 +39,18 @@ class MediaControlsMediaEventListener;
class MediaControlsOrientationLockDelegate;
class MediaControlsWindowEventListener;
class MediaControlCurrentTimeDisplayElement;
+class MediaControlFullscreenButtonElement;
class MediaControlMuteButtonElement;
+class MediaControlOverflowMenuButtonElement;
class MediaControlOverflowMenuListElement;
class MediaControlOverlayEnclosureElement;
+class MediaControlOverlayPlayButtonElement;
class MediaControlPanelElement;
class MediaControlPanelEnclosureElement;
+class MediaControlPlayButtonElement;
class MediaControlRemainingTimeDisplayElement;
class MediaControlTextTrackListElement;
+class MediaControlToggleClosedCaptionsButtonElement;
class ShadowRoot;
// Default implementation of the core/ MediaControls interface used by
@@ -98,13 +103,6 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void BeginScrubbing() override;
void EndScrubbing() override;
void UpdateCurrentTimeDisplay() override;
- void ToggleTextTrackList() override;
- void ShowTextTrackAtIndex(unsigned) override;
- void DisableShowingTextTracks() override;
- // Called by the fullscreen buttons to toggle fulllscreen on/off.
- void EnterFullscreen() override;
- void ExitFullscreen() override;
- void ToggleOverflowMenu() override;
bool OverflowMenuVisible() override;
// TODO(mlamouri): this method is needed in order to notify the controls that
// the `MediaControlsEnabled` setting has changed.
@@ -114,6 +112,18 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
}
Document& OwnerDocument() { return GetDocument(); }
+ // Called by the fullscreen buttons to toggle fulllscreen on/off.
+ void EnterFullscreen();
+ void ExitFullscreen();
+
+ // Text track related methods exposed to components handling closed captions.
+ void ToggleTextTrackList();
+ void ShowTextTrackAtIndex(unsigned);
+ void DisableShowingTextTracks();
+
+ // Toggle the overflow menu visibility.
+ void ToggleOverflowMenu();
+
void ShowOverlayCastButtonIfNeeded();
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698