Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2813103006: Media Controls: move last buttons to modules/. (Closed)

Created:
3 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 8 months ago
Reviewers:
whywhat
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: move last buttons to modules/. Only the two sliders are defined in core/html/shadow and will be moved next. MediaControlElementTypes classes will be moved afterward. BUG=662761 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2813103006 Cr-Commit-Position: refs/heads/master@{#464752} Committed: https://chromium.googlesource.com/chromium/src/+/be87179197a85107c1953022480f5284618b687f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -335 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.h View 2 chunks +0 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 4 chunks +0 lines, -233 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp View 4 chunks +10 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.h View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp View 1 chunk +131 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp View 1 chunk +134 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 8 months ago (2017-04-14 10:48:27 UTC) #3
whywhat
lgtm
3 years, 8 months ago (2017-04-14 16:22:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813103006/1
3 years, 8 months ago (2017-04-14 17:49:50 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 17:59:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be87179197a85107c1953022480f...

Powered by Google App Engine
This is Rietveld 408576698