Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2819363003: Move browser-side File API unittests next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik, jam, dcheng, darin-cc_chromium.org, nhiroki, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move browser-side File API unittests next to the files they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2819363003 Cr-Commit-Position: refs/heads/master@{#465479} Committed: https://chromium.googlesource.com/chromium/src/+/7b57ef309c97d1fd37c5eb83377b7b5e511fb292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6765 lines) Patch
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 chunk +0 lines, -877 lines 0 comments Download
D content/browser/fileapi/dragged_file_util_unittest.cc View 1 chunk +0 lines, -554 lines 0 comments Download
D content/browser/fileapi/file_system_context_unittest.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 chunk +0 lines, -1312 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/browser/fileapi/mock_file_change_observer.h View 1 chunk +0 lines, -103 lines 0 comments Download
D content/browser/fileapi/mock_file_change_observer.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/fileapi/mock_file_update_observer.h View 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/fileapi/mock_file_update_observer.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +0 lines, -2583 lines 0 comments Download
D content/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 chunk +0 lines, -389 lines 0 comments Download
D content/public/test/sandbox_file_system_test_helper.h View 1 chunk +0 lines, -108 lines 0 comments Download
D content/public/test/sandbox_file_system_test_helper.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +0 lines, -14 lines 0 comments Download
D content/test/fileapi_test_file_set.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/test/fileapi_test_file_set.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M storage/browser/BUILD.gn View 4 chunks +14 lines, -0 lines 0 comments Download
A + storage/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/dragged_file_util_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + storage/browser/fileapi/file_system_context_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/obfuscated_file_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + storage/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/fileapi_test_file_set.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/fileapi_test_file_set.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_file_change_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_file_change_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_file_update_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_file_update_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/sandbox_file_system_test_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/sandbox_file_system_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
pwnall
PTAL? The diff count is scary, but the CL is just a bunch of moves ...
3 years, 8 months ago (2017-04-18 20:08:27 UTC) #4
kinuko
lgtm
3 years, 8 months ago (2017-04-19 02:59:56 UTC) #7
pwnall
On 2017/04/19 02:59:56, kinuko wrote: > lgtm Thank you very much for the quick turnaround ...
3 years, 8 months ago (2017-04-19 03:04:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819363003/1
3 years, 8 months ago (2017-04-19 03:04:22 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 03:10:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b57ef309c97d1fd37c5eb83377b...

Powered by Google App Engine
This is Rietveld 408576698