Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2822633004: Compile more targets in file_manager in gyp v2. (Closed)

Created:
3 years, 8 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam, fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile more targets in file_manager in gyp v2. Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js to resolve circular deps. BUG=636289 TEST=run_compiler, try CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2822633004 Cr-Commit-Position: refs/heads/master@{#465095} Committed: https://chromium.googlesource.com/chromium/src/+/25102b38891fb9d46c865a38c8ae04e2660bb6a8

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git cl format --js #

Messages

Total messages: 19 (10 generated)
oka
.
3 years, 8 months ago (2017-04-14 17:13:22 UTC) #2
oka
git cl format --js
3 years, 8 months ago (2017-04-14 17:14:20 UTC) #3
oka
PTAL. @dbeam for ui/webui/** @fukino for ui/file_manager/**
3 years, 8 months ago (2017-04-16 22:24:09 UTC) #9
oka
PTAL. @dbeam for ui/webui/** @fukino for ui/file_manager/**
3 years, 8 months ago (2017-04-16 22:24:11 UTC) #10
fukino
file_manager lgtm
3 years, 8 months ago (2017-04-17 07:21:11 UTC) #12
oka
dbeam@ Friendly ping? (ditto for subsequent CLs.)
3 years, 8 months ago (2017-04-18 01:00:03 UTC) #13
Dan Beam
lgtm \o/
3 years, 8 months ago (2017-04-18 01:10:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822633004/40001
3 years, 8 months ago (2017-04-18 01:12:33 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 01:54:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25102b38891fb9d46c865a38c8ae...

Powered by Google App Engine
This is Rietveld 408576698