Description was changed from ========== Compile more targets in file_manager in gyp v2. Moved constants ...
3 years, 8 months ago
(2017-04-14 17:10:57 UTC)
#1
Description was changed from
==========
Compile more targets in file_manager in gyp v2.
Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.
BUG=636289
==========
to
==========
Compile more targets in file_manager in gyp v2.
Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
oka
.
3 years, 8 months ago
(2017-04-14 17:13:22 UTC)
#2
.
oka
git cl format --js
3 years, 8 months ago
(2017-04-14 17:14:20 UTC)
#3
git cl format --js
oka
The CQ bit was checked by oka@chromium.org to run a CQ dry run
3 years, 8 months ago
(2017-04-14 18:12:04 UTC)
#4
PTAL. @dbeam for ui/webui/** @fukino for ui/file_manager/**
3 years, 8 months ago
(2017-04-16 22:24:09 UTC)
#9
PTAL.
@dbeam for ui/webui/**
@fukino for ui/file_manager/**
oka
PTAL. @dbeam for ui/webui/** @fukino for ui/file_manager/**
3 years, 8 months ago
(2017-04-16 22:24:11 UTC)
#10
PTAL.
@dbeam for ui/webui/**
@fukino for ui/file_manager/**
oka
Description was changed from ========== Compile more targets in file_manager in gyp v2. Moved constants ...
3 years, 8 months ago
(2017-04-16 22:59:05 UTC)
#11
Description was changed from
==========
Compile more targets in file_manager in gyp v2.
Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Compile more targets in file_manager in gyp v2.
Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.
BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
fukino
file_manager lgtm
3 years, 8 months ago
(2017-04-17 07:21:11 UTC)
#12
file_manager lgtm
oka
dbeam@ Friendly ping? (ditto for subsequent CLs.)
3 years, 8 months ago
(2017-04-18 01:00:03 UTC)
#13
dbeam@ Friendly ping? (ditto for subsequent CLs.)
Dan Beam
lgtm \o/
3 years, 8 months ago
(2017-04-18 01:10:53 UTC)
#14
lgtm \o/
oka
The CQ bit was checked by oka@chromium.org
3 years, 8 months ago
(2017-04-18 01:12:13 UTC)
#15
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492477933268480, "parent_rev": "6be56af3695fdc2a5384108fbe01a939073a6a96", "commit_rev": "25102b38891fb9d46c865a38c8ae04e2660bb6a8"}
3 years, 8 months ago
(2017-04-18 01:54:14 UTC)
#17
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492477933268480,
"parent_rev": "6be56af3695fdc2a5384108fbe01a939073a6a96", "commit_rev":
"25102b38891fb9d46c865a38c8ae04e2660bb6a8"}
commit-bot: I haz the power
Description was changed from ========== Compile more targets in file_manager in gyp v2. Moved constants ...
3 years, 8 months ago
(2017-04-18 01:54:20 UTC)
#18
Message was sent while issue was closed.
Description was changed from
==========
Compile more targets in file_manager in gyp v2.
Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.
BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Compile more targets in file_manager in gyp v2.
Moved constants *.METADATA_PREFETCH_PROPERTY_NAMES to constants.js
to resolve circular deps.
BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2822633004
Cr-Commit-Position: refs/heads/master@{#465095}
Committed:
https://chromium.googlesource.com/chromium/src/+/25102b38891fb9d46c865a38c8ae...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/25102b38891fb9d46c865a38c8ae04e2660bb6a8
3 years, 8 months ago
(2017-04-18 01:54:24 UTC)
#19
Issue 2822633004: Compile more targets in file_manager in gyp v2.
(Closed)
Created 3 years, 8 months ago by oka
Modified 3 years, 8 months ago
Reviewers: Dan Beam, fukino
Base URL:
Comments: 0