Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2819743003: 🔍 Refactor LocationBarLayout to fix SearchActivity's location bar (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
agrieve+watch_chromium.org, chromium-reviews, jdonnelly+watch_chromium.org, Yusuf
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

🔍 Refactor LocationBarLayout to fix SearchActivity's location bar * Pull out generic location_bar.xml bits into location_bar_base.xml, then make the original location_bar.xml file include it. This allows the standard LocationBarLayout classes to work as they have before. * Refactor the LocationBarLayout so that it moves some common button updating functionality upwards. * Use a standard layout between phones and tablets. * Fix the SearchActivityLocationBarLayout so that it shows the microphone and delete all buttons. * More carefully align the location bar icons with the suggestion bar icons in both layouts. Screenshots/videos: https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDZXY3c0NPZFJvVW8 BUG=708844, 710945, 711542 Review-Url: https://codereview.chromium.org/2819743003 Cr-Commit-Position: refs/heads/master@{#464797} Committed: https://chromium.googlesource.com/chromium/src/+/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28

Patch Set 1 #

Patch Set 2 : Rebase alone #

Messages

Total messages: 13 (9 generated)
gone
3 years, 8 months ago (2017-04-14 07:20:33 UTC) #2
Ted C
lgtm
3 years, 8 months ago (2017-04-14 20:18:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819743003/20001
3 years, 8 months ago (2017-04-14 20:41:08 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 21:19:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71aff04f37fb3dc76de1fe1dc0bd...

Powered by Google App Engine
This is Rietveld 408576698