Chromium Code Reviews
Description🔍 Refactor LocationBarLayout to fix SearchActivity's location bar
* Pull out generic location_bar.xml bits into location_bar_base.xml,
then make the original location_bar.xml file include it. This allows
the standard LocationBarLayout classes to work as they have before.
* Refactor the LocationBarLayout so that it moves some common button
updating functionality upwards.
* Use a standard layout between phones and tablets.
* Fix the SearchActivityLocationBarLayout so that it shows the microphone
and delete all buttons.
* More carefully align the location bar icons with the suggestion bar
icons in both layouts.
Screenshots/videos:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDZXY3c0NPZFJvVW8
BUG=708844, 710945, 711542
Review-Url: https://codereview.chromium.org/2819743003
Cr-Commit-Position: refs/heads/master@{#464797}
Committed: https://chromium.googlesource.com/chromium/src/+/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28
Patch Set 1 #Patch Set 2 : Rebase alone #Messages
Total messages: 13 (9 generated)
|