Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: chrome/android/java/res/layout/location_bar_base.xml

Issue 2819743003: 🔍 Refactor LocationBarLayout to fix SearchActivity's location bar (Closed)
Patch Set: Rebase alone Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/location_bar.xml ('k') | chrome/android/java/res/layout/search_activity.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/location_bar_base.xml
diff --git a/chrome/android/java/res/layout/location_bar.xml b/chrome/android/java/res/layout/location_bar_base.xml
similarity index 75%
copy from chrome/android/java/res/layout/location_bar.xml
copy to chrome/android/java/res/layout/location_bar_base.xml
index 246255d4aa2394f468321b0760da8481a86f0f92..bcf730aad74453f48fd9a5d3c05e8c49682bb5bd 100644
--- a/chrome/android/java/res/layout/location_bar.xml
+++ b/chrome/android/java/res/layout/location_bar_base.xml
@@ -1,30 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<!-- The location bar also know as URL bar -->
+<!-- Layout for the control group representing Chrome's URL bar on small devices.
+ This file is used for different LocationBarLayout subclasses and should remain generic.
+-->
<merge xmlns:android="http://schemas.android.com/apk/res/android">
- <!-- The container for the Google G is kept at a fixed width to make the horizonal translation
- calculations work. The contents are end-aligned, so when the location bar expands,
- the space in the start margin will be pushed out, creating the effect of both margins
- shrinking simultaneously. -->
- <FrameLayout android:id="@+id/google_g_container"
- android:layout_width="@dimen/location_bar_google_g_container_width"
- android:layout_height="match_parent" >
-
- <ImageView android:id="@+id/google_g"
- style="@style/LocationBarButton"
- android:layout_width="@dimen/location_bar_google_g_width"
- android:layout_height="match_parent"
- android:layout_marginEnd="@dimen/location_bar_google_g_margin"
- android:layout_gravity="end"
- android:scaleType="fitCenter"
- android:src="@drawable/googleg"
- android:contentDescription="@null" />
-
- </FrameLayout>
-
<ImageView android:id="@+id/incognito_badge"
style="@style/LocationBarButton"
android:layout_width="wrap_content"
« no previous file with comments | « chrome/android/java/res/layout/location_bar.xml ('k') | chrome/android/java/res/layout/search_activity.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698