Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/android/java/res/layout/location_bar_base.xml

Issue 2819743003: 🔍 Refactor LocationBarLayout to fix SearchActivity's location bar (Closed)
Patch Set: Rebase alone Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- The location bar also know as URL bar --> 6 <!-- Layout for the control group representing Chrome's URL bar on small devices .
7 This file is used for different LocationBarLayout subclasses and should rem ain generic.
8 -->
7 <merge xmlns:android="http://schemas.android.com/apk/res/android"> 9 <merge xmlns:android="http://schemas.android.com/apk/res/android">
8 <!-- The container for the Google G is kept at a fixed width to make the hor izonal translation
9 calculations work. The contents are end-aligned, so when the location b ar expands,
10 the space in the start margin will be pushed out, creating the effect o f both margins
11 shrinking simultaneously. -->
12 <FrameLayout android:id="@+id/google_g_container"
13 android:layout_width="@dimen/location_bar_google_g_container_width"
14 android:layout_height="match_parent" >
15
16 <ImageView android:id="@+id/google_g"
17 style="@style/LocationBarButton"
18 android:layout_width="@dimen/location_bar_google_g_width"
19 android:layout_height="match_parent"
20 android:layout_marginEnd="@dimen/location_bar_google_g_margin"
21 android:layout_gravity="end"
22 android:scaleType="fitCenter"
23 android:src="@drawable/googleg"
24 android:contentDescription="@null" />
25
26 </FrameLayout>
27
28 <ImageView android:id="@+id/incognito_badge" 10 <ImageView android:id="@+id/incognito_badge"
29 style="@style/LocationBarButton" 11 style="@style/LocationBarButton"
30 android:layout_width="wrap_content" 12 android:layout_width="wrap_content"
31 android:layout_height="match_parent" 13 android:layout_height="match_parent"
32 android:scaleType="center" 14 android:scaleType="center"
33 android:src="@drawable/ic_omnibox_incognito_badge" 15 android:src="@drawable/ic_omnibox_incognito_badge"
34 android:contentDescription="@null" 16 android:contentDescription="@null"
35 android:visibility="gone" /> 17 android:visibility="gone" />
36 18
37 <FrameLayout android:id="@+id/location_bar_icon" 19 <FrameLayout android:id="@+id/location_bar_icon"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 style="@style/LocationBarButton" 76 style="@style/LocationBarButton"
95 android:layout_width="match_parent" 77 android:layout_width="match_parent"
96 android:layout_height="match_parent" 78 android:layout_height="match_parent"
97 android:scaleType="center" 79 android:scaleType="center"
98 android:src="@drawable/btn_mic" 80 android:src="@drawable/btn_mic"
99 android:visibility="invisible" 81 android:visibility="invisible"
100 android:contentDescription="@string/accessibility_toolbar_btn_mic" / > 82 android:contentDescription="@string/accessibility_toolbar_btn_mic" / >
101 83
102 </FrameLayout> 84 </FrameLayout>
103 </merge> 85 </merge>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/location_bar.xml ('k') | chrome/android/java/res/layout/search_activity.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698