Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2819273006: Move //device/sensor impl to be part of the internal implemenation of the Device Service. (Closed)

Created:
3 years, 8 months ago by ke.he
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, riju_, mac-reviews_chromium.org, jam, mlamouri+watch-blink_chromium.org, timvolodine, abarth-chromium, Aaron Boodman, blink-reviews, darin-cc_chromium.org, yzshen+watch_chromium.org, mlamouri+watch-sensors_chromium.org, haraken, einbinder+watch-test-runner_chromium.org, darin (slow to review), agrieve+watch_chromium.org, jochen+watch_chromium.org, qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move //device/sensor impl to be part of the internal implemenation of the Device Service. This is the last step of Servicification of Device Sensor. In this patch: 1) Move the DeviceSensorJni registry from //content into //services. 2) Move all the //device/sensor impl into //services/device. BUG=686707

Patch Set 1 #

Patch Set 2 : Move //device/sensor impl to be part of the internal implemenation of the Device Service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -6007 lines) Patch
M content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/device_sensors/device_light_event_pump.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/device_sensors/device_light_event_pump.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_light_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/test_runner/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/test_runner/test_runner_for_specific_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
M device/generic_sensor/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D device/sensors/BUILD.gn View 1 chunk +0 lines, -110 lines 0 comments Download
D device/sensors/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D device/sensors/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D device/sensors/ambient_light_mac.h View 1 chunk +0 lines, -43 lines 0 comments Download
D device/sensors/ambient_light_mac.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D device/sensors/android/device_sensor_jni_registrar.h View 1 chunk +0 lines, -20 lines 0 comments Download
D device/sensors/android/device_sensor_jni_registrar.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java View 1 chunk +0 lines, -688 lines 0 comments Download
D device/sensors/android/javatests/src/org/chromium/device/sensors/DeviceSensorsTest.java View 1 chunk +0 lines, -645 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory.h View 1 chunk +0 lines, -90 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_android.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_base.h View 1 chunk +0 lines, -103 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_base.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_base_unittest.cc View 1 chunk +0 lines, -609 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_chromeos.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_default.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_mac.cc View 1 chunk +0 lines, -255 lines 0 comments Download
D device/sensors/data_fetcher_shared_memory_win.cc View 1 chunk +0 lines, -482 lines 0 comments Download
D device/sensors/device_sensor_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D device/sensors/device_sensor_host.h View 1 chunk +0 lines, -53 lines 0 comments Download
D device/sensors/device_sensor_host.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D device/sensors/device_sensor_service.h View 1 chunk +0 lines, -78 lines 0 comments Download
D device/sensors/device_sensor_service.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D device/sensors/device_sensors_consts.h View 1 chunk +0 lines, -39 lines 0 comments Download
D device/sensors/public/cpp/BUILD.gn View 1 chunk +0 lines, -53 lines 0 comments Download
D device/sensors/public/cpp/device_light_data.h View 1 chunk +0 lines, -21 lines 0 comments Download
D device/sensors/public/cpp/device_light_hardware_buffer.h View 1 chunk +0 lines, -17 lines 0 comments Download
D device/sensors/public/cpp/device_motion_hardware_buffer.h View 1 chunk +0 lines, -17 lines 0 comments Download
D device/sensors/public/cpp/device_orientation_hardware_buffer.h View 1 chunk +0 lines, -18 lines 0 comments Download
D device/sensors/public/cpp/device_sensors_consts.h View 1 chunk +0 lines, -15 lines 0 comments Download
D device/sensors/public/cpp/device_util_mac.h View 1 chunk +0 lines, -18 lines 0 comments Download
D device/sensors/public/cpp/device_util_mac.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D device/sensors/public/cpp/motion_data.h View 1 chunk +0 lines, -54 lines 0 comments Download
D device/sensors/public/cpp/motion_data.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D device/sensors/public/cpp/orientation_data.h View 1 chunk +0 lines, -38 lines 0 comments Download
D device/sensors/public/cpp/orientation_data.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D device/sensors/public/cpp/shared_memory_seqlock_reader.h View 1 chunk +0 lines, -76 lines 0 comments Download
D device/sensors/public/cpp/shared_memory_seqlock_reader.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D device/sensors/public/interfaces/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D device/sensors/public/interfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/sensors/public/interfaces/light.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D device/sensors/public/interfaces/motion.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D device/sensors/public/interfaces/orientation.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D device/sensors/sensor_manager_android.h View 1 chunk +0 lines, -158 lines 0 comments Download
D device/sensors/sensor_manager_android.cc View 1 chunk +0 lines, -458 lines 0 comments Download
D device/sensors/sensor_manager_android_unittest.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D device/sensors/sensor_manager_chromeos.h View 1 chunk +0 lines, -69 lines 0 comments Download
D device/sensors/sensor_manager_chromeos.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D device/sensors/sensor_manager_chromeos_unittest.cc View 1 chunk +0 lines, -229 lines 0 comments Download
M services/device/BUILD.gn View 4 chunks +15 lines, -6 lines 0 comments Download
M services/device/android/register_jni.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M services/device/device_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/device/device_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/public/cpp/sensors/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/public/cpp/sensors/device_light_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/public/cpp/sensors/device_light_hardware_buffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/device/public/cpp/sensors/device_motion_hardware_buffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/device/public/cpp/sensors/device_orientation_hardware_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/public/cpp/sensors/device_sensors_consts.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/public/cpp/sensors/device_util_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/public/cpp/sensors/device_util_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/public/cpp/sensors/motion_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/public/cpp/sensors/motion_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/public/cpp/sensors/orientation_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/public/cpp/sensors/orientation_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/public/cpp/sensors/shared_memory_seqlock_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/public/cpp/sensors/shared_memory_seqlock_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/device/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A + services/device/public/interfaces/light.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/public/interfaces/motion.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/public/interfaces/orientation.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/sensors/BUILD.gn View 2 chunks +3 lines, -6 lines 0 comments Download
M services/device/sensors/DEPS View 1 chunk +4 lines, -1 line 0 comments Download
A + services/device/sensors/ambient_light_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/sensors/ambient_light_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/sensors/android/device_sensor_jni_registrar.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/sensors/android/device_sensor_jni_registrar.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/sensors/android/javatests/src/org/chromium/device/sensors/DeviceSensorsTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_android.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_base.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_base.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_base_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_default.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_mac.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/device/sensors/data_fetcher_shared_memory_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/sensors/device_sensor_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/sensors/device_sensor_host.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + services/device/sensors/device_sensor_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/device/sensors/device_sensor_service.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + services/device/sensors/device_sensor_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/device/sensors/device_sensor_service_unittest.cc View 1 chunk +13 lines, -12 lines 0 comments Download
A + services/device/sensors/device_sensors_consts.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/device/sensors/sensor_manager_android.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + services/device/sensors/sensor_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/sensors/sensor_manager_android_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/device/sensors/sensor_manager_chromeos.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + services/device/sensors/sensor_manager_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/device/sensors/sensor_manager_chromeos_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (9 generated)
ke.he
The CQ bit was checked by ke.he@intel.com to run a CQ dry run
3 years, 8 months ago (2017-04-19 09:34:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819273006/1
3 years, 8 months ago (2017-04-19 09:35:30 UTC) #2
ke.he
Description was changed from ========== Move //device/sensor impl to be part of the internal implemenation ...
3 years, 8 months ago (2017-04-19 09:45:01 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 09:46:00 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/399902) mac_chromium_rel_ng on ...
3 years, 8 months ago (2017-04-19 09:46:01 UTC) #5
ke.he
The CQ bit was checked by ke.he@intel.com to run a CQ dry run
3 years, 8 months ago (2017-04-19 09:50:17 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819273006/20001
3 years, 8 months ago (2017-04-19 09:50:46 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 10:01:39 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 10:01:40 UTC) #9
Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

Powered by Google App Engine
This is Rietveld 408576698