Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: device/sensors/public/cpp/BUILD.gn

Issue 2819273006: Move //device/sensor impl to be part of the internal implemenation of the Device Service. (Closed)
Patch Set: Move //device/sensor impl to be part of the internal implemenation of the Device Service Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/sensors/device_sensors_consts.h ('k') | device/sensors/public/cpp/device_light_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/sensors/public/cpp/BUILD.gn
diff --git a/device/sensors/public/cpp/BUILD.gn b/device/sensors/public/cpp/BUILD.gn
deleted file mode 100644
index ac26932138c0bd66d22d24cc8aee5a57443e8960..0000000000000000000000000000000000000000
--- a/device/sensors/public/cpp/BUILD.gn
+++ /dev/null
@@ -1,53 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-# This target contains only those files that are shared by the Device Sensors
-# implementation and all Device Sensors clients, including Blink. Add a file
-# here only if it meets the following constraints:
-# (1) It is *necessary* to use the file to consume Device Sensors (the
-# current files define structs that are used as a consistent interpretation of
-# shared memory by the Device Sensor and its clients).
-# (2) The file has no dependencies on the STL or Chromium code and will not
-# grow them over time (the current files are POD structs and will necessarily
-# stay that way due to their above-described purpose).
-# If a file does not meet these constraints, it cannot be used by the Blink
-# client and should be placed in the "full" target below. Similarly, clients
-# without Blink's constraints should depend on the "full" target below rather
-# than this one.
-# Consult {platform-architecture-dev, services-dev}@chromium.org in the case
-# of any uncertainty.
-source_set("shared_with_blink") {
- sources = [
- "motion_data.cc",
- "motion_data.h",
- "orientation_data.cc",
- "orientation_data.h",
- ]
- # Do not add deps here per the above comment.
-}
-
-# This target is a superset of the above one that contains additional optional
-# files available to Device Sensors clients. This target may bring in
-# dependencies on the STL and Chromium code.
-source_set("full") {
- sources = [
- "device_light_data.h",
- "device_light_hardware_buffer.h",
- "device_motion_hardware_buffer.h",
- "device_orientation_hardware_buffer.h",
- "device_sensors_consts.h",
- "device_util_mac.cc",
- "device_util_mac.h",
- "shared_memory_seqlock_reader.cc",
- "shared_memory_seqlock_reader.h",
- ]
-
- deps = [
- "//base",
- ]
- public_deps = [
- ":shared_with_blink",
- "//device/base/synchronization",
- ]
-}
« no previous file with comments | « device/sensors/device_sensors_consts.h ('k') | device/sensors/public/cpp/device_light_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698