Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2818893002:
Strip leading/trailing whitespaces from script URLs in ScriptLoader (Closed)
DescriptionStrip leading/trailing whitespaces from script URLs in ScriptLoader
Previously, leading/trailing whitespaces are not stripped by ScriptLoader
and are removed by URL parser later.
This CL makes ScriptLoader strip the whitespaces, as described in the spec.
This CL makes <script> src attributes that have newline characters in
their leading/trailing whitespaces NOT blocked by [1].
This is consistent with the blocking behavior for <img> src attributes.
This CL doesn't affect <script> src attributes with newlines in the middle.
[1] https://codereview.chromium.org/2794303002
BUG=686281
Review-Url: https://codereview.chromium.org/2818893002
Cr-Commit-Position: refs/heads/master@{#471895}
Committed: https://chromium.googlesource.com/chromium/src/+/ed9ec796e62619560c0a8ca788f3ee1dc49e7c07
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 27 (22 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
lgtm % test rebaselinde
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Strip leading/trailing whitespaces from script URLs BUG= ========== to ========== Strip leading/trailing whitespaces from script URLs BUG= ==========
Description was changed from ========== Strip leading/trailing whitespaces from script URLs BUG= ========== to ========== Strip leading/trailing whitespaces from script URLs BUG=686281 ==========
Description was changed from ========== Strip leading/trailing whitespaces from script URLs BUG=686281 ========== to ========== Strip leading/trailing whitespaces from script URLs This CL change the behavior (TODO: describe the change). BUG=686281 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Strip leading/trailing whitespaces from script URLs This CL change the behavior (TODO: describe the change). BUG=686281 ========== to ========== Strip leading/trailing whitespaces from script URLs in ScriptLoader Previously, leading/trailing whitespaces are not stripped by ScriptLoader and are removed by URL parser later. This CL makes ScriptLoader strip the whitespaces, as described in the spec. This CL makes <script> src attributes that have newline characters in their leading/trailing whitespaces NOT blocked by [1]. This is consistent with the blocking behavior for <img> src attributes. This CL doesn't affect <script> src attributes with newlines in the middle. [1] https://codereview.chromium.org/2794303002 BUG=686281 ==========
hiroshige@chromium.org changed reviewers: + mkwst@chromium.org
+mkwst@, could you also take a look as the author of https://codereview.chromium.org/2794303002?
Sounds reasonable. LGTM.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2818893002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494874137752650,
"parent_rev": "e632dfc199ac43378a3493f10853bfa44c8732dd", "commit_rev":
"ed9ec796e62619560c0a8ca788f3ee1dc49e7c07"}
Message was sent while issue was closed.
Description was changed from ========== Strip leading/trailing whitespaces from script URLs in ScriptLoader Previously, leading/trailing whitespaces are not stripped by ScriptLoader and are removed by URL parser later. This CL makes ScriptLoader strip the whitespaces, as described in the spec. This CL makes <script> src attributes that have newline characters in their leading/trailing whitespaces NOT blocked by [1]. This is consistent with the blocking behavior for <img> src attributes. This CL doesn't affect <script> src attributes with newlines in the middle. [1] https://codereview.chromium.org/2794303002 BUG=686281 ========== to ========== Strip leading/trailing whitespaces from script URLs in ScriptLoader Previously, leading/trailing whitespaces are not stripped by ScriptLoader and are removed by URL parser later. This CL makes ScriptLoader strip the whitespaces, as described in the spec. This CL makes <script> src attributes that have newline characters in their leading/trailing whitespaces NOT blocked by [1]. This is consistent with the blocking behavior for <img> src attributes. This CL doesn't affect <script> src attributes with newlines in the middle. [1] https://codereview.chromium.org/2794303002 BUG=686281 Review-Url: https://codereview.chromium.org/2818893002 Cr-Commit-Position: refs/heads/master@{#471895} Committed: https://chromium.googlesource.com/chromium/src/+/ed9ec796e62619560c0a8ca788f3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ed9ec796e62619560c0a8ca788f3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
