Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2814383004: Remove Modulator::ExecuteModule() temporarily (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Modulator::ExecuteModule() temporarily This is just to reduce dependencies between draft CLs. ExecuteModule() will be re-introduced by https://codereview.chromium.org/2819733002 where it is actually implemented and used. This doesn't change the behavior because ExecuteModule() is not used. BUG=594639 Review-Url: https://codereview.chromium.org/2814383004 Cr-Commit-Position: refs/heads/master@{#464983} Committed: https://chromium.googlesource.com/chromium/src/+/4e89ee1bd9be30cc5566fa434004a763d0610c82

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/Modulator.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
hiroshige
PTAL.
3 years, 8 months ago (2017-04-15 00:55:17 UTC) #6
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-15 01:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814383004/40001
3 years, 8 months ago (2017-04-17 17:47:09 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 19:38:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4e89ee1bd9be30cc5566fa434004...

Powered by Google App Engine
This is Rietveld 408576698