Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 2818893002: Strip leading/trailing whitespaces from script URLs in ScriptLoader (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/local/absolute-url-strip-whitespace-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
index 9179821952ff92e7c1ba8dd44df7ca2df40be32d..38c70e975725dbf40c762806dc442c0c76594bda 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
@@ -344,8 +344,7 @@ bool ScriptLoader::PrepareScript(const TextPosition& script_start_position,
is_external_script_ = true;
// 21.4. "Parse src relative to the element's node document."
- // TODO(hiroshige): Use CompleteURL(src) instead.
- KURL url = element_document.CompleteURL(element_->SourceAttributeValue());
+ KURL url = element_document.CompleteURL(src);
// 21.5. "If the previous step failed, queue a task to
// fire an event named error at the element, and abort these steps."
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/local/absolute-url-strip-whitespace-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698