[DevTools] Swallow mouse up in inspect mode

[DevTools] Swallow mouse up in inspect mode

Currently, we dispatch mouseup to the page after selecting an element in inspect
mode. This could trigger any incovenient side-effects including removal of
inspected element. Swallowing mouseup fixes that problem.

This is not a 100% solution: overlay disappears if user holds mouse
for 2 seconds, and mouseup still gets to the page. That's a minor problem, so
this solution is good enough.

BUG=711320
Review-Url: https://codereview.chromium.org/2818883002
Cr-Commit-Position: refs/heads/master@{#464986}
Committed: https://chromium.googlesource.com/chromium/src/+/88ebc67e440fa500369a453b32ac5f32a7dcbc64

[dgozman, 2017-04-13 23:49:01]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-04-13 23:49:01]

Take a look please.

[pfeldman, 2017-04-14 00:37:39]

https://codereview.chromium.org/2818883002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2818883002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/InspectorOverlay.cpp:772: return
ShouldSearchForNode();
As of this moment, don't update hovered_node_for_inspect_mode_.

[dgozman, 2017-04-14 16:28:44]

Description was changed from

==========
[DevTools] Trigger inspect mode on mouse up, not mouse down

We used to do this on mouse down, which caused mouse up to be
dispatched to the page. This could trigger any incovenient
side-effects including removal of inspected element.
Selecting on mouse up fixes that problem.

BUG=711320
==========

to

==========
[DevTools] Swallow mouse up in inspect mode

Currently, we dispatch mouseup to the page after selecting an element in inspect
mode. This could trigger any incovenient side-effects including removal of
inspected element. Swallowing mouseup fixes that problem.

This is not a 100% solution: overlay disappears if user holds mouse
for 2 seconds, and mouseup still gets to the page. That's a minor problem, so
this solution is good enough.

BUG=711320
==========

[dgozman, 2017-04-14 16:29:11]

What do you think about this approach?

[pfeldman, 2017-04-17 17:45:45]

lgtm

[dgozman, 2017-04-17 17:49:20]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:49:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:42:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492451360912110,
"parent_rev": "3b72f20ce26a682fec86bd299ec304b25b1c2145", "commit_rev":
"88ebc67e440fa500369a453b32ac5f32a7dcbc64"}

[commit-bot: I haz the power, 2017-04-17 19:43:20]

Description was changed from

==========
[DevTools] Swallow mouse up in inspect mode

Currently, we dispatch mouseup to the page after selecting an element in inspect
mode. This could trigger any incovenient side-effects including removal of
inspected element. Swallowing mouseup fixes that problem.

This is not a 100% solution: overlay disappears if user holds mouse
for 2 seconds, and mouseup still gets to the page. That's a minor problem, so
this solution is good enough.

BUG=711320
==========

to

==========
[DevTools] Swallow mouse up in inspect mode

Currently, we dispatch mouseup to the page after selecting an element in inspect
mode. This could trigger any incovenient side-effects including removal of
inspected element. Swallowing mouseup fixes that problem.

This is not a 100% solution: overlay disappears if user holds mouse
for 2 seconds, and mouseup still gets to the page. That's a minor problem, so
this solution is good enough.

BUG=711320

Review-Url: https://codereview.chromium.org/2818883002
Cr-Commit-Position: refs/heads/master@{#464986}
Committed:
https://chromium.googlesource.com/chromium/src/+/88ebc67e440fa500369a453b32ac...
==========

[commit-bot: I haz the power, 2017-04-17 19:43:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88ebc67e440fa500369a453b32ac...