Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2818883002: [DevTools] Swallow mouse up in inspect mode (Closed)
Patch Set: better Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 3954ddced19d0a5f26d46eb7fbc5dd90bdb74a64..412f7c3460848192a9cdbef63683675daefed857 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -193,6 +193,7 @@ InspectorOverlay::InspectorOverlay(WebLocalFrameImpl* frame_impl)
show_reloading_blanket_(false),
in_layout_(false),
needs_update_(false),
+ swallow_next_mouse_up_(false),
inspect_mode_(InspectorDOMAgent::kNotSearching) {}
InspectorOverlay::~InspectorOverlay() {
@@ -263,7 +264,9 @@ bool InspectorOverlay::HandleInputEvent(const WebInputEvent& input_event) {
if (mouse_event.GetType() == WebInputEvent::kMouseMove)
handled = HandleMouseMove(mouse_event);
else if (mouse_event.GetType() == WebInputEvent::kMouseDown)
- handled = HandleMousePress();
+ handled = HandleMouseDown();
+ else if (mouse_event.GetType() == WebInputEvent::kMouseUp)
+ handled = HandleMouseUp();
if (handled)
return true;
@@ -766,11 +769,13 @@ bool InspectorOverlay::HandleMouseMove(const WebMouseEvent& event) {
return true;
}
-bool InspectorOverlay::HandleMousePress() {
+bool InspectorOverlay::HandleMouseDown() {
+ swallow_next_mouse_up_ = false;
if (!ShouldSearchForNode())
return false;
if (hovered_node_for_inspect_mode_) {
+ swallow_next_mouse_up_ = true;
Inspect(hovered_node_for_inspect_mode_.Get());
hovered_node_for_inspect_mode_.Clear();
return true;
@@ -778,6 +783,14 @@ bool InspectorOverlay::HandleMousePress() {
return false;
}
+bool InspectorOverlay::HandleMouseUp() {
+ if (swallow_next_mouse_up_) {
+ swallow_next_mouse_up_ = false;
+ return true;
+ }
+ return false;
+}
+
bool InspectorOverlay::HandleGestureEvent(const WebGestureEvent& event) {
if (!ShouldSearchForNode() || event.GetType() != WebInputEvent::kGestureTap)
return false;
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698