Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.h

Issue 2818883002: [DevTools] Swallow mouse up in inspect mode (Closed)
Patch Set: better Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 const IntPoint& document_scroll_offset); 124 const IntPoint& document_scroll_offset);
125 void EvaluateInOverlay(const String& method, const String& argument); 125 void EvaluateInOverlay(const String& method, const String& argument);
126 void EvaluateInOverlay(const String& method, 126 void EvaluateInOverlay(const String& method,
127 std::unique_ptr<protocol::Value> argument); 127 std::unique_ptr<protocol::Value> argument);
128 void OnTimer(TimerBase*); 128 void OnTimer(TimerBase*);
129 void RebuildOverlayPage(); 129 void RebuildOverlayPage();
130 void Invalidate(); 130 void Invalidate();
131 void ScheduleUpdate(); 131 void ScheduleUpdate();
132 void ClearInternal(); 132 void ClearInternal();
133 133
134 bool HandleMousePress(); 134 bool HandleMouseDown();
135 bool HandleMouseUp();
135 bool HandleGestureEvent(const WebGestureEvent&); 136 bool HandleGestureEvent(const WebGestureEvent&);
136 bool HandleTouchEvent(const WebTouchEvent&); 137 bool HandleTouchEvent(const WebTouchEvent&);
137 bool HandleMouseMove(const WebMouseEvent&); 138 bool HandleMouseMove(const WebMouseEvent&);
138 bool ShouldSearchForNode(); 139 bool ShouldSearchForNode();
139 void Inspect(Node*); 140 void Inspect(Node*);
140 141
141 Member<WebLocalFrameImpl> frame_impl_; 142 Member<WebLocalFrameImpl> frame_impl_;
142 String paused_in_debugger_message_; 143 String paused_in_debugger_message_;
143 Member<Node> highlight_node_; 144 Member<Node> highlight_node_;
144 Member<Node> event_target_node_; 145 Member<Node> event_target_node_;
145 InspectorHighlightConfig node_highlight_config_; 146 InspectorHighlightConfig node_highlight_config_;
146 std::unique_ptr<FloatQuad> highlight_quad_; 147 std::unique_ptr<FloatQuad> highlight_quad_;
147 Member<Page> overlay_page_; 148 Member<Page> overlay_page_;
148 Member<InspectorOverlayChromeClient> overlay_chrome_client_; 149 Member<InspectorOverlayChromeClient> overlay_chrome_client_;
149 Member<InspectorOverlayHost> overlay_host_; 150 Member<InspectorOverlayHost> overlay_host_;
150 InspectorHighlightConfig quad_highlight_config_; 151 InspectorHighlightConfig quad_highlight_config_;
151 bool draw_view_size_; 152 bool draw_view_size_;
152 bool resize_timer_active_; 153 bool resize_timer_active_;
153 bool omit_tooltip_; 154 bool omit_tooltip_;
154 TaskRunnerTimer<InspectorOverlay> timer_; 155 TaskRunnerTimer<InspectorOverlay> timer_;
155 bool suspended_; 156 bool suspended_;
156 bool show_reloading_blanket_; 157 bool show_reloading_blanket_;
157 bool in_layout_; 158 bool in_layout_;
158 bool needs_update_; 159 bool needs_update_;
159 v8_inspector::V8InspectorSession* v8_session_; 160 v8_inspector::V8InspectorSession* v8_session_;
160 Member<InspectorDOMAgent> dom_agent_; 161 Member<InspectorDOMAgent> dom_agent_;
161 std::unique_ptr<PageOverlay> page_overlay_; 162 std::unique_ptr<PageOverlay> page_overlay_;
162 Member<Node> hovered_node_for_inspect_mode_; 163 Member<Node> hovered_node_for_inspect_mode_;
164 bool swallow_next_mouse_up_;
163 InspectorDOMAgent::SearchMode inspect_mode_; 165 InspectorDOMAgent::SearchMode inspect_mode_;
164 std::unique_ptr<InspectorHighlightConfig> inspect_mode_highlight_config_; 166 std::unique_ptr<InspectorHighlightConfig> inspect_mode_highlight_config_;
165 }; 167 };
166 168
167 } // namespace blink 169 } // namespace blink
168 170
169 #endif // InspectorOverlay_h 171 #endif // InspectorOverlay_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698