Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2816103002: [Media] Access bg video finch trial params directly from the renderer (Closed)

Created:
3 years, 8 months ago by whywhat
Modified:
3 years, 8 months ago
CC:
Alexei Svitkine (slow), chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media] Access bg video finch trial params directly from the renderer BUG=None TEST=manual (via command line flags) Review-Url: https://codereview.chromium.org/2816103002 Cr-Commit-Position: refs/heads/master@{#464588} Committed: https://chromium.googlesource.com/chromium/src/+/7f17f41b9c68b7553fd1b4f61f47b6c4a01859a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
whywhat
PTaL rsesek for content/public/common/common_param_traits_macros.h avi for content/* cc: asvitkine FYI
3 years, 8 months ago (2017-04-13 20:50:46 UTC) #2
whywhat
+jam for content/ as avi seems to be OOO
3 years, 8 months ago (2017-04-13 20:58:41 UTC) #4
Robert Sesek
lgtm
3 years, 8 months ago (2017-04-13 20:59:47 UTC) #5
Avi (use Gerrit)
lgtm This is sweet. Do it.
3 years, 8 months ago (2017-04-13 21:20:18 UTC) #6
whywhat
Thanks Avi! :)
3 years, 8 months ago (2017-04-13 21:24:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816103002/1
3 years, 8 months ago (2017-04-13 21:25:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:55:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f17f41b9c68b7553fd1b4f61f47...

Powered by Google App Engine
This is Rietveld 408576698