Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2818643003: Use NodeAsRangeFirstNode() as Range::FirstNode() again. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by yoichio
Modified:
6 months, 1 week ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NodeAsRangeFirstNode() as Range::FirstNode() and NodeAsRangePastLastNode() as Range::PastLastNode(). This was introduced once 2 years ago: https://codereview.chromium.org/1000533004 but reverted of crash: https://codereview.chromium.org/1121633004 Now original code won't crash because {start/end}Position() doesn't return Null Position since: https://codereview.chromium.org/2812733003 TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html Review-Url: https://codereview.chromium.org/2818643003 Cr-Commit-Position: refs/heads/master@{#464358} Committed: https://chromium.googlesource.com/chromium/src/+/4074f42f1c8360b2f429549b8819f4d9f604ebd4

Patch Set 1 #

Total comments: 4

Patch Set 2 : update #

Messages

Total messages: 26 (18 generated)
yoichio
6 months, 1 week ago (2017-04-13 05:07:36 UTC) #7
yoichio
6 months, 1 week ago (2017-04-13 05:07:43 UTC) #8
yosin_UTC9
https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/core/dom/Range.cpp#newcode1436 third_party/WebKit/Source/core/dom/Range.cpp:1436: return StartPosition().ToOffsetInAnchor().NodeAsRangeFirstNode(); We don't need to use |ToOffsetInAnchor()| here. ...
6 months, 1 week ago (2017-04-13 05:45:46 UTC) #13
yoichio
https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/core/dom/Range.cpp File third_party/WebKit/Source/core/dom/Range.cpp (right): https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/core/dom/Range.cpp#newcode1436 third_party/WebKit/Source/core/dom/Range.cpp:1436: return StartPosition().ToOffsetInAnchor().NodeAsRangeFirstNode(); On 2017/04/13 05:45:45, yosin_UTC9 wrote: > We ...
6 months, 1 week ago (2017-04-13 06:04:39 UTC) #15
yosin_UTC9
lgtm +tkent@ for OWNERS review
6 months, 1 week ago (2017-04-13 06:30:03 UTC) #18
tkent
lgtm
6 months, 1 week ago (2017-04-13 06:34:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818643003/20001
6 months, 1 week ago (2017-04-13 09:26:45 UTC) #23
commit-bot: I haz the power
6 months, 1 week ago (2017-04-13 09:31:38 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4074f42f1c8360b2f429549b8819...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa