Use NodeAsRangeFirstNode() as Range::FirstNode() again.

Use NodeAsRangeFirstNode() as Range::FirstNode() and
 NodeAsRangePastLastNode() as Range::PastLastNode().

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html

Review-Url: https://codereview.chromium.org/2818643003
Cr-Commit-Position: refs/heads/master@{#464358}
Committed: https://chromium.googlesource.com/chromium/src/+/4074f42f1c8360b2f429549b8819f4d9f604ebd4

[yoichio, 2017-04-13 03:50:15]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 03:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-04-13 03:53:27]

Description was changed from

==========
Use Position in range

TEST=
==========

to

==========
Use Position in range

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html
==========

[yoichio, 2017-04-13 03:54:21]

Description was changed from

==========
Use Position in range

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html
==========

to

==========
Use NodeAsRangeFirstNode as Range::FirstNode again.

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html
==========

[yoichio, 2017-04-13 03:55:27]

Description was changed from

==========
Use NodeAsRangeFirstNode as Range::FirstNode again.

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html
==========

to

==========
Use NodeAsRangeFirstNode() as Range::FirstNode() and
 NodeAsRangePastLastNode() as Range::PastLastNode().

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html
==========

[yoichio, 2017-04-13 05:07:36]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-04-13 05:25:04]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 05:25:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:34:03]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-13 05:45:46]

https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1436: return
StartPosition().ToOffsetInAnchor().NodeAsRangeFirstNode();
We don't need to use |ToOffsetInAnchor()| here.
|Position::NodeAsRangeFirstNode()| does so.
BTW, we would like to call |ToOffsetInAnchor()| in
|Position::NodeAsRangeFirstNode()|.

https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1440: return
EndPosition().ToOffsetInAnchor().NodeAsRangePastLastNode();
We don't need to use |ToOffsetInAnchor()| here.
|Position::NodeAsRangePastLastNode()| does so.
BTW, we would like to call |ToOffsetInAnchor()| in
|Position::NodeAsRangePastLastNode()|.

[yoichio, 2017-04-13 06:04:33]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[yoichio, 2017-04-13 06:04:39]

https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1436: return
StartPosition().ToOffsetInAnchor().NodeAsRangeFirstNode();
On 2017/04/13 05:45:45, yosin_UTC9 wrote:
> We don't need to use |ToOffsetInAnchor()| here.
> |Position::NodeAsRangeFirstNode()| does so.
> BTW, we would like to call |ToOffsetInAnchor()| in
> |Position::NodeAsRangeFirstNode()|.

Done.

https://codereview.chromium.org/2818643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1440: return
EndPosition().ToOffsetInAnchor().NodeAsRangePastLastNode();
On 2017/04/13 05:45:45, yosin_UTC9 wrote:
> We don't need to use |ToOffsetInAnchor()| here.
> |Position::NodeAsRangePastLastNode()| does so.
> BTW, we would like to call |ToOffsetInAnchor()| in
> |Position::NodeAsRangePastLastNode()|.

Done.

[commit-bot: I haz the power, 2017-04-13 06:05:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-04-13 06:30:03]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-04-13 06:30:03]

lgtm

+tkent@ for OWNERS review

[tkent, 2017-04-13 06:34:42]

lgtm

[commit-bot: I haz the power, 2017-04-13 07:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 07:32:43]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-04-13 09:26:24]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-04-13 09:26:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 09:30:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492075584178510,
"parent_rev": "a15de7e2276f1ccaf8392b4268002f2979a246a5", "commit_rev":
"4074f42f1c8360b2f429549b8819f4d9f604ebd4"}

[commit-bot: I haz the power, 2017-04-13 09:31:38]

Description was changed from

==========
Use NodeAsRangeFirstNode() as Range::FirstNode() and
 NodeAsRangePastLastNode() as Range::PastLastNode().

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html
==========

to

==========
Use NodeAsRangeFirstNode() as Range::FirstNode() and
 NodeAsRangePastLastNode() as Range::PastLastNode().

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003


TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html

Review-Url: https://codereview.chromium.org/2818643003
Cr-Commit-Position: refs/heads/master@{#464358}
Committed:
https://chromium.googlesource.com/chromium/src/+/4074f42f1c8360b2f429549b8819...
==========

[commit-bot: I haz the power, 2017-04-13 09:31:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4074f42f1c8360b2f429549b8819...