Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2812733003: Let RangeboundaryPoint::container_node_ be reference. (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
tkent, hayato, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Let RangeboundaryPoint::container_node_ be reference. That's because no one assigns nullptr to the member. TEST=No change in behavior Review-Url: https://codereview.chromium.org/2812733003 Cr-Commit-Position: refs/heads/master@{#463976} Committed: https://chromium.googlesource.com/chromium/src/+/36e6d2dc0e6df037867d5de56630f2e52e2267ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -91 lines) Patch
M third_party/WebKit/Source/core/dom/Range.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 32 chunks +82 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
yoichio
3 years, 8 months ago (2017-04-11 07:48:58 UTC) #5
yosin_UTC9
lgtm Good catch!
3 years, 8 months ago (2017-04-11 09:31:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812733003/1
3 years, 8 months ago (2017-04-11 12:16:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/407835)
3 years, 8 months ago (2017-04-11 12:23:23 UTC) #13
yoichio
tkent, PTAL.
3 years, 8 months ago (2017-04-12 01:48:07 UTC) #14
yoichio
tkent is off today. hayato, PTAL as OWNER.
3 years, 8 months ago (2017-04-12 07:55:54 UTC) #16
hayato
lgtm
3 years, 8 months ago (2017-04-12 07:59:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812733003/1
3 years, 8 months ago (2017-04-12 08:01:19 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 09:34:31 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36e6d2dc0e6df037867d5de56630...

Powered by Google App Engine
This is Rietveld 408576698