Remove parent_level field of function type parameters.

Remove parent_level field of function type parameters.
Add function_type_arguments field in closure instances.
Lots of other smaller changes, also related to generic function semantics.
This is still work in progress, with a change of direction in the design:
The type argument vector of a generic function will be prepended with the type
arguments of enclosing generic functions. The re-allocation and concatenation
will be done in nested generic function's prolog. This will greatly simplify
instantiation of types at run time without having to search the context for
parent function's type arguments. However, a closure instance now requires an
additional field. On the other hand, type parameters do not require a
parent_level field anymore.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/fd5089c9e81f865b1151ae3184421845f5635a86

[regis, 2017-04-15 00:16:48]

regis@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, zra@google.com

[rmacnak, 2017-04-15 01:00:50]

LGTM w/c

https://codereview.chromium.org/2818273002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/2818273002/diff/1/runtime/lib/mirrors.cc#newc...
runtime/lib/mirrors.cc:1479: // function_type_arguments.
Hm, that'll be annoying because type vectors are not instances. I'm content to
keep dropping function type parameters here until someone complains.

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:519: empty_type_arguments_ =
TypeArguments::ReadOnlyHandle();
Also add this to the two functions called AddVMIsolateBaseObjects.

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/raw_object.h#new...
runtime/vm/raw_object.h:1791: RawTypeArguments* function_type_arguments_;
:(

[regis, 2017-04-17 15:49:38]

Thanks Ryan!

If Siva or Zach have more comments, I'll address them in a later cl. There will
be plenty more.

https://codereview.chromium.org/2818273002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/2818273002/diff/1/runtime/lib/mirrors.cc#newc...
runtime/lib/mirrors.cc:1479: // function_type_arguments.
On 2017/04/15 01:00:50, rmacnak wrote:
> Hm, that'll be annoying because type vectors are not instances. I'm content to
> keep dropping function type parameters here until someone complains.

I also thought it is not high priority right now. Once someone complains, I
guess we can add another fake type holding the function type arguments.

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:519: empty_type_arguments_ =
TypeArguments::ReadOnlyHandle();
On 2017/04/15 01:00:50, rmacnak wrote:
> Also add this to the two functions called AddVMIsolateBaseObjects.

Done.

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/2818273002/diff/1/runtime/vm/raw_object.h#new...
runtime/vm/raw_object.h:1791: RawTypeArguments* function_type_arguments_;
On 2017/04/15 01:00:50, rmacnak wrote:
> :(

Yeah, sorry. No free lunch.

[regis, 2017-04-17 15:58:30]

Description was changed from

==========
Remove parent_level field of function type parameters.
Add function_type_arguments field in closure instances.
Lots of other smaller changes, also related to generic function semantics.
This is still work in progress, with a change of direction in the design:
The type argument vector of a generic function will be prepended with the type
arguments of enclosing generic functions. The re-allocation and concatenation
will be done in nested generic function's prolog. This will greatly simplify
instantiation of types at run time without having to search the context for
parent function's type arguments. However, a closure instance now requires an
additional field. On the other hand, type parameters do not require a
parent_level field anymore.
==========

to

==========
Remove parent_level field of function type parameters.
Add function_type_arguments field in closure instances.
Lots of other smaller changes, also related to generic function semantics.
This is still work in progress, with a change of direction in the design:
The type argument vector of a generic function will be prepended with the type
arguments of enclosing generic functions. The re-allocation and concatenation
will be done in nested generic function's prolog. This will greatly simplify
instantiation of types at run time without having to search the context for
parent function's type arguments. However, a closure instance now requires an
additional field. On the other hand, type parameters do not require a
parent_level field anymore.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fd5089c9e81f865b1151ae3184421845f5635a86
==========

[regis, 2017-04-17 15:58:34]

Committed patchset #2 (id:20001) manually as
fd5089c9e81f865b1151ae3184421845f5635a86 (presubmit successful).