Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: runtime/lib/mirrors.cc

Issue 2818273002: Remove parent_level field of function type parameters. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/function.dart ('k') | runtime/vm/bootstrap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index b64cda34ae4c088f820bf8cbdd85c096d57300bc..89d4f7b2fdab88d282c649838118d1d56190cab7 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -1471,8 +1471,12 @@ DEFINE_NATIVE_ENTRY(ClosureMirror_function, 1) {
Type& instantiator = Type::Handle();
if (closure.IsClosure()) {
- const TypeArguments& arguments =
- TypeArguments::Handle(Closure::Cast(closure).instantiator());
+ const TypeArguments& arguments = TypeArguments::Handle(
+ Closure::Cast(closure).instantiator_type_arguments());
+ // TODO(regis): Mirrors need work to properly support generic functions.
+ // The 'instantiator' created below should not be a type, but two type
+ // argument vectors: instantiator_type_arguments and
+ // function_type_arguments.
const Class& cls =
Class::Handle(Isolate::Current()->object_store()->object_class());
instantiator = Type::New(cls, arguments, TokenPosition::kNoSource);
« no previous file with comments | « runtime/lib/function.dart ('k') | runtime/vm/bootstrap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698