runtime/vm/stub_code_mips.cc - Issue 2818273002: Remove parent_level field of function type parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 2818273002: Remove parent_level field of function type parameters. (Closed)

Patch Set: address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_mips.cc

diff --git a/runtime/vm/stub_code_mips.cc b/runtime/vm/stub_code_mips.cc

index 50f7305af3dd4a81802bd53c0fd3a6d15fd22219..8cd843b8179799904eebf775bdd9ec6f071a66e0 100644

--- a/runtime/vm/stub_code_mips.cc

+++ b/runtime/vm/stub_code_mips.cc

@@ -1902,7 +1902,9 @@ static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {

// T7: null.

__ SmiTag(T0);

__ BranchNotEqual(T0, Immediate(Smi::RawValue(kClosureCid)), &loop);

- __ lw(T1, FieldAddress(A0, Closure::instantiator_offset()));

+ __ lw(T1, FieldAddress(A0, Closure::function_type_arguments_offset()));

+ __ bne(T1, T7, &not_found); // Cache cannot be used for generic closures.

+ __ lw(T1, FieldAddress(A0, Closure::instantiator_type_arguments_offset()));

__ lw(T0, FieldAddress(A0, Closure::function_offset()));

// T0: instance class id as Smi or function.

__ Bind(&loop);

« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »