Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: runtime/vm/stub_code_arm.cc

Issue 2818273002: Remove parent_level field of function type parameters. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/simulator_dbc.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 1771 matching lines...) Expand 10 before | Expand all | Expand 10 after
1782 // R4: instance type arguments (null if none), used only if n > 1. 1782 // R4: instance type arguments (null if none), used only if n > 1.
1783 __ ldr(R3, FieldAddress(R3, SubtypeTestCache::cache_offset())); 1783 __ ldr(R3, FieldAddress(R3, SubtypeTestCache::cache_offset()));
1784 __ AddImmediate(R3, Array::data_offset() - kHeapObjectTag); 1784 __ AddImmediate(R3, Array::data_offset() - kHeapObjectTag);
1785 1785
1786 Label loop, found, not_found, next_iteration; 1786 Label loop, found, not_found, next_iteration;
1787 // R3: entry start. 1787 // R3: entry start.
1788 // R8: instance class id. 1788 // R8: instance class id.
1789 // R4: instance type arguments (still null if closure). 1789 // R4: instance type arguments (still null if closure).
1790 __ SmiTag(R8); 1790 __ SmiTag(R8);
1791 __ CompareImmediate(R8, Smi::RawValue(kClosureCid)); 1791 __ CompareImmediate(R8, Smi::RawValue(kClosureCid));
1792 __ ldr(R4, FieldAddress(R0, Closure::instantiator_offset()), EQ); 1792 __ b(&loop, NE);
1793 __ ldr(R8, FieldAddress(R0, Closure::function_offset()), EQ); 1793 __ ldr(R4, FieldAddress(R0, Closure::function_type_arguments_offset()));
1794 __ CompareObject(R4, Object::null_object());
1795 __ b(&not_found, NE); // Cache cannot be used for generic closures.
1796 __ ldr(R4, FieldAddress(R0, Closure::instantiator_type_arguments_offset()));
1797 __ ldr(R8, FieldAddress(R0, Closure::function_offset()));
1794 // R8: instance class id as Smi or function. 1798 // R8: instance class id as Smi or function.
1795 __ Bind(&loop); 1799 __ Bind(&loop);
1796 __ ldr(R9, 1800 __ ldr(R9,
1797 Address(R3, kWordSize * SubtypeTestCache::kInstanceClassIdOrFunction)); 1801 Address(R3, kWordSize * SubtypeTestCache::kInstanceClassIdOrFunction));
1798 __ CompareObject(R9, Object::null_object()); 1802 __ CompareObject(R9, Object::null_object());
1799 __ b(&not_found, EQ); 1803 __ b(&not_found, EQ);
1800 __ cmp(R9, Operand(R8)); 1804 __ cmp(R9, Operand(R8));
1801 if (n == 1) { 1805 if (n == 1) {
1802 __ b(&found, EQ); 1806 __ b(&found, EQ);
1803 } else { 1807 } else {
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
2309 } 2313 }
2310 2314
2311 2315
2312 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) { 2316 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) {
2313 __ bkpt(0); 2317 __ bkpt(0);
2314 } 2318 }
2315 2319
2316 } // namespace dart 2320 } // namespace dart
2317 2321
2318 #endif // defined TARGET_ARCH_ARM 2322 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/simulator_dbc.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698