Fully deprecate core.js. Moved last method to error.js.

Fully deprecate core.js. Moved last method to error.js.

This is the last CL to split core.js into better encapsulated parts.
Also updated all references to web/web_state/js/resources/core.js in all
comments.

BUG=614092
Review-Url: https://codereview.chromium.org/2817943002
Cr-Commit-Position: refs/heads/master@{#464528}
Committed: https://chromium.googlesource.com/chromium/src/+/0adc0ccf7a830e33e26d1d19a87f8e38bede7477

[danyao, 2017-04-13 16:08:17]

danyao@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-13 16:30:06]

\o/ lgtm!

https://codereview.chromium.org/2817943002/diff/1/ios/chrome/browser/ui/conte...
File ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js
(right):

https://codereview.chromium.org/2817943002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js:789: //
Should this use context_menu.js's elementFromPoint_() instead?
Would you mind filing a bug and adding a TODO for this?

https://codereview.chromium.org/2817943002/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/error.js (right):

https://codereview.chromium.org/2817943002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/error.js:18: * added ASAP to catch any errors in
startup. Note this does not appear to
Could you please drop "Note this does not appear to work in iOS < 5." Currently
minimum supported iOS version is 9.

https://codereview.chromium.org/2817943002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/error.js:22: // Sadly, event.filename and
event.lineno are always 'undefined' and '0'
WKWebView may support this now. Could you please file a bug and add a TODO for
this.

[danyao, 2017-04-13 17:40:45]

https://codereview.chromium.org/2817943002/diff/1/ios/chrome/browser/ui/conte...
File ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js
(right):

https://codereview.chromium.org/2817943002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js:789: //
Should this use context_menu.js's elementFromPoint_() instead?
On 2017/04/13 16:30:06, Eugene But wrote:
> Would you mind filing a bug and adding a TODO for this?

Done.

https://codereview.chromium.org/2817943002/diff/1/ios/web/web_state/js/resour...
File ios/web/web_state/js/resources/error.js (right):

https://codereview.chromium.org/2817943002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/error.js:18: * added ASAP to catch any errors in
startup. Note this does not appear to
On 2017/04/13 16:30:06, Eugene But wrote:
> Could you please drop "Note this does not appear to work in iOS < 5."
Currently
> minimum supported iOS version is 9.

Done.

https://codereview.chromium.org/2817943002/diff/1/ios/web/web_state/js/resour...
ios/web/web_state/js/resources/error.js:22: // Sadly, event.filename and
event.lineno are always 'undefined' and '0'
On 2017/04/13 16:30:06, Eugene But wrote:
> WKWebView may support this now. Could you please file a bug and add a TODO for
> this.

Done.

[danyao, 2017-04-13 19:25:57]

The CQ bit was checked by danyao@chromium.org

[danyao, 2017-04-13 19:25:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2817943002/#ps30001
(title: "Tweak language")

[commit-bot: I haz the power, 2017-04-13 19:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:29:05]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1492111557036550,
"parent_rev": "7ca3add13622c453c70565b8a21255133bc39687", "commit_rev":
"0adc0ccf7a830e33e26d1d19a87f8e38bede7477"}

[commit-bot: I haz the power, 2017-04-13 20:29:53]

Description was changed from

==========
Fully deprecate core.js. Moved last method to error.js.

This is the last CL to split core.js into better encapsulated parts.
Also updated all references to web/web_state/js/resources/core.js in all
comments.

BUG=614092
==========

to

==========
Fully deprecate core.js. Moved last method to error.js.

This is the last CL to split core.js into better encapsulated parts.
Also updated all references to web/web_state/js/resources/core.js in all
comments.

BUG=614092

Review-Url: https://codereview.chromium.org/2817943002
Cr-Commit-Position: refs/heads/master@{#464528}
Committed:
https://chromium.googlesource.com/chromium/src/+/0adc0ccf7a830e33e26d1d19a87f...
==========

[commit-bot: I haz the power, 2017-04-13 20:29:53]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/0adc0ccf7a830e33e26d1d19a87f...