Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2817943002: Fully deprecate core.js. Moved last method to error.js. (Closed)
Patch Set: Tweak language Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/js/resources/web_bundle.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 7548d116d32576a82a5da770fd1bb4f750dc7b8b..ddd16776867f016d38fd77a40dbd8e8c84627cd6 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -4942,11 +4942,12 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
};
// When navigating via WKBackForwardListItem to pages created or updated by
- // calls to pushState() and replaceState(), sometimes core.js is not injected
- // correctly. This means that calling window.history navigation functions
- // will invoke WKWebView's non-overridden implementations, causing a mismatch
- // between the WKBackForwardList and NavigationManager.
- // TODO(crbug.com/659816): Figure out how to prevent core.js injection flake.
+ // calls to pushState() and replaceState(), sometimes web_bundle.js is not
+ // injected correctly. This means that calling window.history navigation
+ // functions will invoke WKWebView's non-overridden implementations, causing a
+ // mismatch between the WKBackForwardList and NavigationManager.
+ // TODO(crbug.com/659816): Figure out how to prevent web_bundle.js injection
+ // flake.
if (currentItem->HasStateBeenReplaced() ||
currentItem->IsCreatedFromPushState()) {
defaultNavigationBlock();
« no previous file with comments | « ios/web/web_state/js/resources/web_bundle.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698