Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Also moved didFinishNavigation() from core.js to legacy.js. This
method can probably eventually be removed (see crbug.com/546350). For
now, it is most closely related to navigation so cleaner to put it
there instead of creating a separate .js file.

This removes two of the last three methods in core.js.

BUG=614092
TESTED=Ran ios_chrome_unittests and passed.

Review-Url: https://codereview.chromium.org/2810263002
Cr-Commit-Position: refs/heads/master@{#464488}
Committed: https://chromium.googlesource.com/chromium/src/+/c1ff136fb8f5e327c7f2a70066c1c33cff539911

[danyao, 2017-04-12 20:38:49]

danyao@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-12 21:33:08]

lgtm

https://codereview.chromium.org/2810263002/diff/20001/ios/web/web_state/js/re...
File ios/web/web_state/js/resources/navigation.js (right):

https://codereview.chromium.org/2810263002/diff/20001/ios/web/web_state/js/re...
ios/web/web_state/js/resources/navigation.js:74: __gCrWeb.didFinishNavigation =
function() {
Do you want to move this to legacy.js instead?

[danyao, 2017-04-12 22:11:24]

Description was changed from

==========
Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Also moved didFinishNavigation() from core.js to navigation.js. This
method can probably eventually be removed (see crbug.com/546350). For
now, it is most closely related to navigation so cleaner to put it
there instead of creating a separate .js file.

This removes two of the last three methods in core.js.

BUG=614092
TESTED=Ran ios_chrome_unittests and passed.
==========

to

==========
Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Also moved didFinishNavigation() from core.js to legacy.js. This
method can probably eventually be removed (see crbug.com/546350). For
now, it is most closely related to navigation so cleaner to put it
there instead of creating a separate .js file.

This removes two of the last three methods in core.js.

BUG=614092
TESTED=Ran ios_chrome_unittests and passed.
==========

[danyao, 2017-04-12 22:13:26]

On 2017/04/12 21:33:08, Eugene But wrote:
> lgtm
> 
>
https://codereview.chromium.org/2810263002/diff/20001/ios/web/web_state/js/re...
> File ios/web/web_state/js/resources/navigation.js (right):
> 
>
https://codereview.chromium.org/2810263002/diff/20001/ios/web/web_state/js/re...
> ios/web/web_state/js/resources/navigation.js:74: __gCrWeb.didFinishNavigation
=
> function() {
> Do you want to move this to legacy.js instead?

Done. Also updated BUILD.gn, web_bundle.js as a result. PTAL.

[danyao, 2017-04-13 16:50:21]

The CQ bit was checked by danyao@chromium.org

[danyao, 2017-04-13 16:50:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2810263002/#ps40001
(title: "Moved didFinishNavigation to legacy.js")

[commit-bot: I haz the power, 2017-04-13 16:50:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:05:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492102221486510,
"parent_rev": "060c140872ae52c49ba012edc39a39b0a09040cf", "commit_rev":
"c1ff136fb8f5e327c7f2a70066c1c33cff539911"}

[commit-bot: I haz the power, 2017-04-13 19:06:34]

Description was changed from

==========
Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Also moved didFinishNavigation() from core.js to legacy.js. This
method can probably eventually be removed (see crbug.com/546350). For
now, it is most closely related to navigation so cleaner to put it
there instead of creating a separate .js file.

This removes two of the last three methods in core.js.

BUG=614092
TESTED=Ran ios_chrome_unittests and passed.
==========

to

==========
Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Also moved didFinishNavigation() from core.js to legacy.js. This
method can probably eventually be removed (see crbug.com/546350). For
now, it is most closely related to navigation so cleaner to put it
there instead of creating a separate .js file.

This removes two of the last three methods in core.js.

BUG=614092
TESTED=Ran ios_chrome_unittests and passed.

Review-Url: https://codereview.chromium.org/2810263002
Cr-Commit-Position: refs/heads/master@{#464488}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1ff136fb8f5e327c7f2a70066c1...
==========

[commit-bot: I haz the power, 2017-04-13 19:06:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c1ff136fb8f5e327c7f2a70066c1...