Invalidate the "values cache" when resetting animated value state

Invalidate the "values cache" when resetting animated value state

When we revalidate the animated value, and the value 'source' is the
'values' attribute, we need to also reset the cached 'from' and 'to'
values kept in SVGAnimationElement. If not, a target change could clear
the animated from/to values and not notice that they are stale on
revalidation.
Companion to https://codereview.chromium.org/2763283002.

BUG=710247
Review-Url: https://codereview.chromium.org/2817643003
Cr-Commit-Position: refs/heads/master@{#464037}
Committed: https://chromium.googlesource.com/chromium/src/+/c1d98a208cadc9b2ee92a82f641f026f1df9490d

[fs, 2017-04-12 13:03:39]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 13:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-12 13:04:29]

Description was changed from

==========
Invalidate the "values cache" when resetting animated value state

When we revalidate the animated value, and the value 'source' is the
'values' attribute, we need to also reset the cached 'from' and 'to'
values kept in SVGAnimationElement. If not, a target change could clear
the animated from/to values and not notice that they are stale on
revalidation.

BUG=710247
==========

to

==========
Invalidate the "values cache" when resetting animated value state

When we revalidate the animated value, and the value 'source' is the
'values' attribute, we need to also reset the cached 'from' and 'to'
values kept in SVGAnimationElement. If not, a target change could clear
the animated from/to values and not notice that they are stale on
revalidation.
Companion to https://codereview.chromium.org/2763283002.

BUG=710247
==========

[commit-bot: I haz the power, 2017-04-12 14:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 14:25:21]

Dry run: This issue passed the CQ dry run.

[fs, 2017-04-12 14:28:07]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2017-04-12 15:24:58]

lgtm

[fs, 2017-04-12 15:32:16]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-04-12 15:32:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:41:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492011136827670, "parent_rev":
"02dc9f2819cf895bc4ec0dd2a67a90435c58f1bc", "commit_rev":
"c1d98a208cadc9b2ee92a82f641f026f1df9490d"}

[commit-bot: I haz the power, 2017-04-12 15:42:08]

Description was changed from

==========
Invalidate the "values cache" when resetting animated value state

When we revalidate the animated value, and the value 'source' is the
'values' attribute, we need to also reset the cached 'from' and 'to'
values kept in SVGAnimationElement. If not, a target change could clear
the animated from/to values and not notice that they are stale on
revalidation.
Companion to https://codereview.chromium.org/2763283002.

BUG=710247
==========

to

==========
Invalidate the "values cache" when resetting animated value state

When we revalidate the animated value, and the value 'source' is the
'values' attribute, we need to also reset the cached 'from' and 'to'
values kept in SVGAnimationElement. If not, a target change could clear
the animated from/to values and not notice that they are stale on
revalidation.
Companion to https://codereview.chromium.org/2763283002.

BUG=710247

Review-Url: https://codereview.chromium.org/2817643003
Cr-Commit-Position: refs/heads/master@{#464037}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1d98a208cadc9b2ee92a82f641f...
==========

[commit-bot: I haz the power, 2017-04-12 15:42:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1d98a208cadc9b2ee92a82f641f...