Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2763283002: Revalidate SMIL animation value after target change (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revalidate SMIL animation value after target change When a target moves in the tree, the animation value was invalidated, but never revalidated again when the element was reinserted. Make sure to signal a revalidation if there's an active interval and the the animation is running after the target element was reinserted. BUG=701128 Review-Url: https://codereview.chromium.org/2763283002 Cr-Commit-Position: refs/heads/master@{#459150} Committed: https://chromium.googlesource.com/chromium/src/+/f70d58032706670f094ed7ae73c2bb13259fc0b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/svg/animations/target-move-crash.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/animations/target-move-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
fs
3 years, 9 months ago (2017-03-22 20:01:26 UTC) #7
Stephen Chennney
LGTM
3 years, 9 months ago (2017-03-23 16:19:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763283002/1
3 years, 9 months ago (2017-03-23 16:36:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/380186)
3 years, 9 months ago (2017-03-23 16:51:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763283002/1
3 years, 9 months ago (2017-03-23 17:16:56 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 18:20:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f70d58032706670f094ed7ae73c2...

Powered by Google App Engine
This is Rietveld 408576698