Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimationElement.h

Issue 2817643003: Invalidate the "values cache" when resetting animated value state (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2008 Cameron McCormack <cam@mcc.id.au>
7 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 } 130 }
131 void SetCalcMode(CalcMode calc_mode) { calc_mode_ = calc_mode; } 131 void SetCalcMode(CalcMode calc_mode) { calc_mode_ = calc_mode; }
132 132
133 // Parses a list of values as specified by SVG, stripping leading 133 // Parses a list of values as specified by SVG, stripping leading
134 // and trailing whitespace, and places them in result. If the 134 // and trailing whitespace, and places them in result. If the
135 // format of the string is not valid, parseValues empties result 135 // format of the string is not valid, parseValues empties result
136 // and returns false. See 136 // and returns false. See
137 // http://www.w3.org/TR/SVG/animate.html#ValuesAttribute . 137 // http://www.w3.org/TR/SVG/animate.html#ValuesAttribute .
138 static bool ParseValues(const String&, Vector<String>& result); 138 static bool ParseValues(const String&, Vector<String>& result);
139 139
140 void InvalidatedValuesCache();
140 void AnimationAttributeChanged() override; 141 void AnimationAttributeChanged() override;
141 142
142 private: 143 private:
143 bool IsValid() const final { return SVGTests::IsValid(); } 144 bool IsValid() const final { return SVGTests::IsValid(); }
144 145
145 virtual bool CalculateToAtEndOfDurationValue( 146 virtual bool CalculateToAtEndOfDurationValue(
146 const String& to_at_end_of_duration_string) = 0; 147 const String& to_at_end_of_duration_string) = 0;
147 virtual bool CalculateFromAndToValues(const String& from_string, 148 virtual bool CalculateFromAndToValues(const String& from_string,
148 const String& to_string) = 0; 149 const String& to_string) = 0;
149 virtual bool CalculateFromAndByValues(const String& from_string, 150 virtual bool CalculateFromAndByValues(const String& from_string,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 Vector<gfx::CubicBezier> key_splines_; 184 Vector<gfx::CubicBezier> key_splines_;
184 String last_values_animation_from_; 185 String last_values_animation_from_;
185 String last_values_animation_to_; 186 String last_values_animation_to_;
186 CalcMode calc_mode_; 187 CalcMode calc_mode_;
187 AnimationMode animation_mode_; 188 AnimationMode animation_mode_;
188 }; 189 };
189 190
190 } // namespace blink 191 } // namespace blink
191 192
192 #endif // SVGAnimationElement_h 193 #endif // SVGAnimationElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698